chore: Add integ tests for single page funnels #1671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1671 +/- ##
=======================================
Coverage 94.20% 94.20%
=======================================
Files 650 650
Lines 17539 17539
Branches 5776 5776
=======================================
Hits 16522 16522
Misses 948 948
Partials 69 69 ☔ View full report in Codecov by Sentry. |
michaeldowseza
force-pushed
the
analytics/integ-tests
branch
from
dd58ea2
to
20b0765
Compare
michaeldowseza
force-pushed
the
analytics/integ-tests
branch
from
20b0765
to
d893b11
Compare
michaeldowseza
force-pushed
the
analytics/integ-tests
branch
from
d893b11
to
1f3428a
Compare
michaeldowseza
force-pushed
the
analytics/integ-tests
branch
from
1f3428a
to
e43516b
Compare
michaeldowseza
force-pushed
the
analytics/integ-tests
branch
from
e43516b
to
14f941f
Compare
This adds tests for the existing behaviour. It includes some fix mes that were found while writing and is intended as a start to testing.
michaeldowseza
force-pushed
the
analytics/integ-tests
branch
from
14f941f
to
9236679
Compare
connorlanigan
approved these changes
Oct 25, 2023
| }, | ||
|
|
||
| funnelSubStepError(props): void { | ||
| const stepName = document.querySelector(props.stepNameSelector)!.innerHTML; |
There was a problem hiding this comment.
In some places you've used ? and in some places you've used !. I'd recommend to use ? everywhere, so that we still have the event even when some data is missing
|
|
||
| describe('Embedded Form', () => { | ||
| test.skip( | ||
| 'Forms embedded in Modal unrelataed to the main Form', |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds tests for the existing behaviour. It includes some fix mes that were found while writing and is intended as a start to testing.
Related links, issue #, if available: n/a
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.