New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Use a centralized announcer to make aria-live announcements #2128

Draft

avinashbot wants to merge 9 commits into main from announcer-prototype

Draft

feat: Use a centralized announcer to make aria-live announcements #2128

Add tests for button loadingText.

Codecov / codecov/patch failed Oct 20, 2024 in 1s

93.80% of diff hit (target 96.21%)

View this Pull Request on Codecov

93.80% of diff hit (target 96.21%)

Annotations

Check warning on line 254 in src/button/internal.tsx

codecov / codecov/patch

src/button/internal.tsx#L254

Added line #L254 was not covered by tests

Check warning on line 54 in src/internal/components/live-region/controller.ts

codecov / codecov/patch

src/internal/components/live-region/controller.ts#L53-L54

Added lines #L53 - L54 were not covered by tests

Check warning on line 68 in src/internal/components/live-region/controller.ts

codecov / codecov/patch

src/internal/components/live-region/controller.ts#L67-L68

Added lines #L67 - L68 were not covered by tests

Check warning on line 85 in src/internal/components/live-region/controller.ts

codecov / codecov/patch

src/internal/components/live-region/controller.ts#L85

Added line #L85 was not covered by tests

Check warning on line 80 in src/internal/components/live-region/internal.tsx

codecov / codecov/patch

src/internal/components/live-region/internal.tsx#L80

Added line #L80 was not covered by tests

View more details on Codecov