Updating the L1TrackObjectNtupleMaker with genJet information and using the SimVertex collection

[BenjaminRS]

PR description:

This PR resolves the issue reported here: #1097
Namely it fixes the generator level vertex to use the SimVertex collection (from Geant4 SimHits).

PR validation:

This PR passes the following checks:


• scram b
• scram b code-format
• scram b code-checks
• time cmsRun L1Trigger/L1TTrackMatch/test/L1TrackObjectNtupleMaker_cfg.py

As a quick validation that this fixes the genVertex collection in the desired way I performed a quick test using L1TrackObjectNtupleMaker_cfg.py by:
Adding before L1TrackObjectNtupleMaker_cfg.py#L101:
process.l1tVertexFinder.VertexReconstruction.FH_NVtx = cms.uint32(1)
To give just 1 reconstructed PV per event and I saw:

Before fixing the genVertex collection I saw:

After fixing the genVertex collection I saw:

The fixed genVertex collection more closely matches what I would expect based on the reconstructed values.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This PR will need to be ported to Master too.

[triggerDoctor]

Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation.

Attempts to compile this PR succeeded!

Info	Value
return code	0
command	eval scramv1 runtime -sh && scram b -j 8

[triggerDoctor]

Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation.

I found no issues with the code checks!

Info	Value
return code	0
command	eval scramv1 runtime -sh && scram b -k -j 8 code-checks && scram b -k -j 8 code-checks

I found no issues with the headers!

Info	Value
return code	0
command	eval scramv1 runtime -sh && scram b -k -j 8 check-headers

[triggerDoctor]

Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation.

Attempts to compile this PR succeeded!

Info	Value
return code	0
command	eval scramv1 runtime -sh && scram b -j 8

[triggerDoctor]

Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation.

I found no issues with the code checks!

Info	Value
return code	0
command	eval scramv1 runtime -sh && scram b -k -j 8 code-checks && scram b -k -j 8 code-checks

I found no issues with the headers!

Info	Value
return code	0
command	eval scramv1 runtime -sh && scram b -k -j 8 check-headers

[triggerDoctor]

Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation.

I found 3 files that did not meet formatting requirements:

• L1Trigger/L1TMuon/src/MicroGMTConfiguration.cc
• L1Trigger/Phase2L1GMT/interface/TPSLUTs.h
• L1Trigger/Phase2L1GMT/plugins/Phase2L1TGMTFwdMuonTranslator.cc

Please run scram b code-format to auto-apply code formatting

Info	Value
return code	0
command	eval scramv1 runtime -sh && scram b -k -j 8 code-format-all

[triggerDoctor]

Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation.

This PR passes available unit tests!

Info	Value
return code	0
command	eval scramv1 runtime -sh && scram b runtests

[triggerDoctor]

Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation

I found a non-zero return code running the relval workflows for this PR!

Info	Value
return code	1
command	eval scramv1 runtime -sh && runTheMatrix.py --what upgrade -l 26834.78

[epalencia]

@BenjaminRS , can you open the corresponding PR in master?