Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ROOT6] Updated root to tip of branch master #7872

Merged
merged 1 commit into from
May 17, 2022
Merged

[ROOT6] Updated root to tip of branch master #7872

merged 1 commit into from
May 17, 2022

Conversation

aandvalenzuela
Copy link
Contributor

No description provided.

@aandvalenzuela
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @aandvalenzuela (Andrea Valenzuela) for branch IB/CMSSW_12_4_X/rootmaster.

@smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @qliphy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bd4d7f/24745/summary.html
COMMIT: 4ab88ef
CMSSW: CMSSW_12_4_X_2022-05-16-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/7872/24745/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bd4d7f/24745/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bd4d7f/24745/git-merge-result

Build

I found compilation error when building:

Traceback (most recent call last):
  File "/cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc10/cms/cmssw-patch/CMSSW_12_4_X_2022-05-16-1100/src/FWCore/Utilities/scripts/edmCheckClassVersion", line 181, in 
    raise RuntimeError("failed to load library '"+options.library+"'")
RuntimeError: failed to load library 'libAnalysisDataFormatsTrackInfo.so'
Suggestion: You can run 'scram build updateclassversion' to generate src/AnalysisDataFormats/TrackInfo/src/classes_def.xml.generated with updated ClassVersion
gmake: *** [tmp/slc7_amd64_gcc10/edm_checks/libAnalysisDataFormatsTrackInfo.so] Error 1
@@@@ ----> OK  EDM Class Version 
>> Checking EDM Class Transients in libCUDADataFormatsEcalRecHitSoA.so
>> Checking EDM Class Version for src/CUDADataFormats/SiPixelCluster/src/classes_def.xml in libCUDADataFormatsSiPixelCluster.so
@@@@ ----> OK  EDM Class Version 
>> Checking EDM Class Transients in libAlignmentCocoaFit.so

@smuzaffar smuzaffar changed the base branch from IB/CMSSW_12_4_X/rootmaster to IB/CMSSW_12_5_X/rootmaster May 16, 2022 20:31
@smuzaffar
Copy link
Contributor

please test

@smuzaffar smuzaffar merged commit f975a5d into cms-sw:IB/CMSSW_12_5_X/rootmaster May 17, 2022
@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bd4d7f/24763/summary.html
COMMIT: 4ab88ef
CMSSW: CMSSW_12_5_ROOT6_X_2022-05-16-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/7872/24763/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test SiStripDAQ_O2O_test had ERRORS

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-bd4d7f/11634.301_TTbar_14TeV+2021_Run3FS+TTbar_14TeV_TuneCP5_GenSim+HARVESTNano

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 16118 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3663214
  • DQMHistoTests: Total failures: 38760
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3624431
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 2060.1080000000006 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 1000.0,... ): 4.691 KiB RPC/Muon
  • DQMHistoSizes: changed ( 1000.0,... ): 2.046 KiB RPC/AllHits
  • DQMHistoSizes: changed ( 1000.0,... ): 0.958 KiB RPC/EventInfo
  • DQMHistoSizes: changed ( 10024.0,... ): 13.123 KiB RPC/Muon
  • DQMHistoSizes: changed ( 10024.0,... ): 10.091 KiB RPC/AllHits
  • DQMHistoSizes: changed ( 10024.0,... ): 1.654 KiB L1T/L1TStage2EMTF
  • DQMHistoSizes: changed ( 11634.0,... ): 61.076 KiB RPC/Muon
  • DQMHistoSizes: changed ( 11634.0,... ): 58.100 KiB RPC/AllHits
  • DQMHistoSizes: changed ( 11834.0 ): 2.249 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 23234.0,... ): 53.604 KiB RPC/Muon
  • DQMHistoSizes: changed ( 23234.0 ): ...
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: found differences in 6 / 49 workflows

@cmsbuild cmsbuild mentioned this pull request Aug 16, 2022
Merged
@cmsbuild cmsbuild mentioned this pull request Jun 7, 2023
Closed
@cmsbuild cmsbuild mentioned this pull request Aug 7, 2023
Merged
@cmsbuild cmsbuild mentioned this pull request Sep 28, 2023
Closed
@cmsbuild cmsbuild mentioned this pull request Oct 23, 2023
Merged
@cmsbuild cmsbuild mentioned this pull request Nov 22, 2023
Merged
@cmsbuild cmsbuild mentioned this pull request Feb 2, 2024
Merged
This was referenced Feb 19, 2024
Closed
Merged
@cmsbuild cmsbuild mentioned this pull request Apr 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
externals-pending orp-pending pending-signatures tests-rejected
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aandvalenzuela @cmsbuild @smuzaffar