Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ROOT6] Updated root to tip of branch master #9151

Conversation

aandvalenzuela
Copy link
Contributor

ROOT version is still 6.33.01.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @aandvalenzuela for branch IB/CMSSW_14_1_X/rootmaster.

@iarspider, @aandvalenzuela, @cmsbuild, @smuzaffar can you please review it and eventually sign? Thanks.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 22, 2024

cms-bot internal usage

@aandvalenzuela
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-27fe18/38985/summary.html
COMMIT: 40c0ec9
CMSSW: CMSSW_14_1_ROOT6_X_2024-04-21-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/9151/38985/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation error when building:

Call Stack (most recent call first):
CMakeLists.txt:117 (include)


-- Configuring incomplete, errors occurred!
error: Bad exit status from /pool/condor/dir_573710/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.tPplBn (%build)


RPM build errors:
line 37: It's not recommended to have unversioned Obsoletes: Obsoletes: lcg+root+6.33.01-2620a6d0847aa18e86f9aa4d21ff2c78
Macro expanded in comment on line 368: %{pkginstroot}/lib


@cmsbuild
Copy link
Contributor

Pull request #9151 was updated.

@aandvalenzuela
Copy link
Contributor Author

Removing build option due to:

-- Cannot enable cudnn without enabling cuda or tmva-gpu: cudnn is disabled.
CMake Error at cmake/modules/RootBuildOptions.cmake:402 (message):
>>> 'builtin_afterimage' is no longer part of ROOT 6.33.01 build options.
Call Stack (most recent call first):
CMakeLists.txt:117 (include)

@aandvalenzuela
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-27fe18/38994/summary.html
COMMIT: 57f5ab0
CMSSW: CMSSW_14_1_ROOT6_X_2024-04-21-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/9151/38994/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 1 errors in the following unit tests:

---> test testSchemaEvolution had ERRORS

Comparison Summary

Summary:

@smuzaffar
Copy link
Contributor

please test with cms-sw/cmssw#44804

@smuzaffar
Copy link
Contributor

please test with cms-sw/cmssw#44804 for CMSSW_14_1_ROOT6_X

@cms-sw cms-sw deleted a comment from cmsbuild Apr 24, 2024
@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-27fe18/39040/summary.html
COMMIT: 57f5ab0
CMSSW: CMSSW_14_1_ROOT6_X_2024-04-22-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/9151/39040/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-27fe18/39040/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-27fe18/39040/git-merge-result

Comparison Summary

Summary:

@smuzaffar
Copy link
Contributor

lets get this in and see what else fails for ROOT6 IBs. the failing unit tests should be fixed once cms-sw/cmssw#44804 is merged

@smuzaffar smuzaffar merged commit 4e01510 into cms-sw:IB/CMSSW_14_1_X/rootmaster Apr 24, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants