Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ROOT::TAttMarker class version #44804

Merged
merged 1 commit into from
May 1, 2024

Conversation

smuzaffar
Copy link
Contributor

For root master branch TAttMarker class def version has been updated. This change is needed to integrate latest ROOT master changes in ROOT6 IBs (cms-sw/cmsdist#9151).

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 22, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44804/40052

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar for master.

It involves the following packages:

  • DQMServices/Components (dqm)

@nothingface0, @antoniovagnerini, @tjavaid, @cmsbuild, @syuvivida, @rvenditti can you please review it and eventually sign? Thanks.
@barvic this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-df9313/39022/summary.html
COMMIT: 578ca39
CMSSW: CMSSW_14_1_X_2024-04-22-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44804/39022/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@smuzaffar
Copy link
Contributor Author

@cms-sw/dqm-l2 , can you please review this change? Note that TAttMarker class def version has been updated for root master so we need this change to go in to test latest root master changes.

@smuzaffar
Copy link
Contributor Author

@cms-sw/dqm-l2 , can you please review this change?

@tjavaid
Copy link

tjavaid commented Apr 30, 2024

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit a04cdfd into cms-sw:master May 1, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants