(Un)packers for hadronic showers at the uGMT input and output #35627

dinyar · 2021-10-12T16:44:08Z

PR description:

This PR extends the RegionalMuon and Muon unpackers to be able to also unpack RegionalMuonShower and MuonShower objects respectively. This functionality is gated by the expected uGMT firmware version read from the readout payload.

I've also modified the RegionalMuonShower interface to more closely mirror that of the RegionalMuonCand data format.

PR validation:

Ran scram build code-checks, runTheMatrix.py -l limited -i all --ibeos, and scram b runtests locally.

attn @rekovic, @kbunkow, @dildick

cmsbuild · 2021-10-12T16:57:42Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35627/25899

This PR adds an extra 52KB to repository

cmsbuild · 2021-10-12T16:58:07Z

A new Pull Request was created by @dinyar (Dinyar Rabady) for master.

It involves the following packages:

DataFormats/L1TMuon (l1)
EventFilter/L1TRawToDigi (l1)
L1Trigger/L1TMuon (l1)
L1Trigger/L1TMuonEndCap (l1)

@cmsbuild, @rekovic, @cecilecaillol can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @rovere, @thomreis this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

rekovic · 2021-10-13T13:35:06Z

please test

cmsbuild · 2021-10-13T13:47:43Z

-1

Failed Tests: Build ClangBuild
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5bb56a/19597/summary.html
COMMIT: 59fa1a6
CMSSW: CMSSW_12_1_X_2021-10-13-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35627/19597/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation warning when building: See details on the summary page.

Clang Build

I found compilation warning while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 32 COMPILER='llvm compile'

See details on the summary page.

cmsbuild · 2021-10-13T14:15:40Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35627/25923

This PR adds an extra 56KB to repository

cmsbuild · 2021-10-13T14:16:17Z

Pull request #35627 was updated. @cmsbuild, @rekovic, @cecilecaillol can you please check and sign again.

rekovic · 2021-10-13T15:18:34Z

please test

cmsbuild · 2021-10-13T19:02:39Z

-1

Failed Tests: AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5bb56a/19603/summary.html
COMMIT: 3a8d88c
CMSSW: CMSSW_12_1_X_2021-10-13-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35627/19603/install.sh to create a dev area with all the needed externals and cmssw changes.

AddOn Tests

hlt_data_GRun

----- Begin Fatal Exception 13-Oct-2021 17:46:07 CEST-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing  Event run: 323775 lumi: 99 event: 111372621 stream: 0
   [1] Running path 'RAWoutput_step'
   [2] Prefetching for module PoolOutputModule/'RAWoutput'
   [3] Prefetching for module RawDataCollectorByLabel/'rawDataCollector'
   [4] Prefetching for module L1TDigiToRaw/'packGmtStage2'
   [5] Prefetching for module L1TMuonEndCapShowerProducer/'simEmtfShowers'
   [6] Calling method for module CSCTriggerPrimitivesProducer/'simCscTriggerPrimitiveDigis'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: MuonDigiCollection<GEMDetId,GEMPadDigiCluster>
Looking for module label: simMuonGEMPadDigiClusters
Looking for productInstanceName: 

   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.

----- End Fatal Exception -------------------------------------------------

hlt_data_HIon

----- Begin Fatal Exception 13-Oct-2021 17:46:09 CEST-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing  Event run: 325112 lumi: 6 event: 29040 stream: 3
   [1] Running path 'RAWoutput_step'
   [2] Prefetching for module PoolOutputModule/'RAWoutput'
   [3] Prefetching for module RawDataCollectorByLabel/'rawDataCollector'
   [4] Prefetching for module L1TDigiToRaw/'packGmtStage2'
   [5] Prefetching for module L1TMuonEndCapShowerProducer/'simEmtfShowers'
   [6] Calling method for module CSCTriggerPrimitivesProducer/'simCscTriggerPrimitiveDigis'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: MuonDigiCollection<GEMDetId,GEMPadDigiCluster>
Looking for module label: simMuonGEMPadDigiClusters
Looking for productInstanceName: 

   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.

----- End Fatal Exception -------------------------------------------------

hlt_data_PIon

----- Begin Fatal Exception 13-Oct-2021 17:48:33 CEST-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing  Event run: 323775 lumi: 99 event: 111372621 stream: 0
   [1] Running path 'RAWoutput_step'
   [2] Prefetching for module PoolOutputModule/'RAWoutput'
   [3] Prefetching for module RawDataCollectorByLabel/'rawDataCollector'
   [4] Prefetching for module L1TDigiToRaw/'packGmtStage2'
   [5] Prefetching for module L1TMuonEndCapShowerProducer/'simEmtfShowers'
   [6] Calling method for module CSCTriggerPrimitivesProducer/'simCscTriggerPrimitiveDigis'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: MuonDigiCollection<GEMDetId,GEMPadDigiCluster>
Looking for module label: simMuonGEMPadDigiClusters
Looking for productInstanceName: 

   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.

----- End Fatal Exception -------------------------------------------------

Expand to see more addon errors ...

hlt_data_PRef

Comparison Summary

Summary:

No significant changes to the logs found
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 40
DQMHistoTests: Total histograms compared: 2796791
DQMHistoTests: Total failures: 42141
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2754628
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 39 files compared)
Checked 169 log files, 37 edm output root files, 40 DQM output files
TriggerResults: found differences in 5 / 39 workflows

jfernan2 · 2021-12-08T12:43:09Z

+1

rekovic · 2021-12-09T09:54:41Z

+1

cmsbuild · 2021-12-09T09:55:09Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

perrotta · 2021-12-09T10:02:19Z

+1

VinInn · 2021-12-09T13:50:31Z

this breaks #36396

dinyar · 2021-12-09T13:59:49Z

I suspect 9960aaa caught the other PR out. If that's the issue I can commit a fix for it in the next hour or two I'd say.

perrotta · 2021-12-09T14:25:12Z

As far as I can see the inconsistency is with #36018, which was merged 2 days ago after this PR was tested last
@dinyar if you have a quick fix at hand, please commit the PR: otherwise we'll have to revert this one.

perrotta · 2021-12-09T14:37:22Z

Also https://github.com/cms-sw/cmssw/pull/36018/files#diff-a2194e73035b8a64c72a7363af81ce438a545aca33b67ce5f616ff6ed98b4d0cR15 and https://github.com/cms-sw/cmssw/pull/36018/files#diff-a2194e73035b8a64c72a7363af81ce438a545aca33b67ce5f616ff6ed98b4d0cR16 , the issue being the removal here of the two methods

RegionalMuonShower::endcap()
RegionalMuonShower::sector()

which should be restored.

zuoxunwu · 2021-12-09T14:41:33Z

the line that does not compile is
https://github.com/cms-sw/cmssw/pull/36396/files#diff-881ff4a5b7f865747240faa761540efae46b58c1007078bcda43fbfe6f250f6bR62
and another farther below

As @dinyar is already fixing the conflict by encapsulating RegionalMuonShower::endcap() and RegionalMuonShower::sector(). I should keep these lines as they are, right?

VinInn · 2021-12-09T14:43:59Z

This is what I suggested as the quickest and robust fix to be merged before next IB.
A cleaner solution can be provided at a later time (if deemed necessary)

zuoxunwu · 2021-12-09T14:48:00Z

Agree. Thanks!

cmsbuild added this to the CMSSW_12_1_X milestone Oct 12, 2021

cmsbuild added code-checks-pending l1-pending orp-pending pending-signatures tests-pending labels Oct 12, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 12, 2021

cmsbuild added tests-started and removed tests-pending labels Oct 13, 2021

cmsbuild added tests-rejected and removed tests-started labels Oct 13, 2021

dinyar force-pushed the hadronic_shower_unpacker-12_1_X-dev branch from 59fa1a6 to 3a8d88c Compare October 13, 2021 14:08

cmsbuild added code-checks-pending tests-pending and removed tests-rejected code-checks-approved labels Oct 13, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 13, 2021

cmsbuild added tests-started and removed tests-pending labels Oct 13, 2021

cmsbuild removed the tests-started label Oct 13, 2021

cmsbuild added tests-approved and removed tests-started labels Dec 8, 2021

cmsbuild added dqm-approved and removed dqm-pending labels Dec 8, 2021

cmsbuild added fully-signed l1-approved and removed l1-pending pending-signatures labels Dec 9, 2021

cmsbuild added orp-approved and removed orp-pending labels Dec 9, 2021

cmsbuild merged commit a45ef05 into cms-sw:master Dec 9, 2021

cmsbuild mentioned this pull request Dec 9, 2021

Use cooperative groups to populate Associations (Histograms) in Pixel Patatrack #35713

Open

VinInn mentioned this pull request Dec 9, 2021

Master (next IB) is broken (two inconsistent PR were merged independently) #36433

Closed

VinInn mentioned this pull request Dec 9, 2021

Add data-vs-emulator plots for L1T shower DQM #36396

Merged

This was referenced Dec 9, 2021

Temporarily restore sector and endcap accessors to RegionalMuonShower #36435

Merged

[Do not merge] testing bot #36437

Closed

[12.3.X] Move to root 6.24 cms-sw/cmsdist#7500

Merged

[ROOT624] Testing root 62.4 for gcc10 cms-sw/cmsdist#7505

Closed

dinyar mentioned this pull request Mar 13, 2022

Backport muon shower (un)packing and DQM to 12_2_X #37225

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

(Un)packers for hadronic showers at the uGMT input and output #35627

(Un)packers for hadronic showers at the uGMT input and output #35627

dinyar commented Oct 12, 2021

cmsbuild commented Oct 12, 2021

cmsbuild commented Oct 12, 2021

rekovic commented Oct 13, 2021

cmsbuild commented Oct 13, 2021

cmsbuild commented Oct 13, 2021

cmsbuild commented Oct 13, 2021

rekovic commented Oct 13, 2021

cmsbuild commented Oct 13, 2021

jfernan2 commented Dec 8, 2021

rekovic commented Dec 9, 2021

cmsbuild commented Dec 9, 2021

perrotta commented Dec 9, 2021

VinInn commented Dec 9, 2021

dinyar commented Dec 9, 2021

perrotta commented Dec 9, 2021

perrotta commented Dec 9, 2021 •

edited

Loading

zuoxunwu commented Dec 9, 2021

VinInn commented Dec 9, 2021

zuoxunwu commented Dec 9, 2021

(Un)packers for hadronic showers at the uGMT input and output #35627

(Un)packers for hadronic showers at the uGMT input and output #35627

Conversation

dinyar commented Oct 12, 2021

PR description:

PR validation:

cmsbuild commented Oct 12, 2021

cmsbuild commented Oct 12, 2021

rekovic commented Oct 13, 2021

cmsbuild commented Oct 13, 2021

Build

Clang Build

cmsbuild commented Oct 13, 2021

cmsbuild commented Oct 13, 2021

rekovic commented Oct 13, 2021

cmsbuild commented Oct 13, 2021

AddOn Tests

Comparison Summary

jfernan2 commented Dec 8, 2021

rekovic commented Dec 9, 2021

cmsbuild commented Dec 9, 2021

perrotta commented Dec 9, 2021

VinInn commented Dec 9, 2021

dinyar commented Dec 9, 2021

perrotta commented Dec 9, 2021

perrotta commented Dec 9, 2021 • edited Loading

zuoxunwu commented Dec 9, 2021

VinInn commented Dec 9, 2021

zuoxunwu commented Dec 9, 2021

perrotta commented Dec 9, 2021 •

edited

Loading