-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add data-vs-emulator plots for L1T shower DQM #36396
Add data-vs-emulator plots for L1T shower DQM #36396
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36396/27199
|
A new Pull Request was created by @zuoxunwu (Xunwu Zuo) for master. It involves the following packages:
@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-879a18/21074/summary.html Comparison SummarySummary:
|
@zuoxunwu the added plots apper empty in all tested workflows, is this expected? Specially L1TEMU / L1TdeStage2EMTF / Shower |
@jfernan2 Thanks for checking. Yes, it is expected. |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
does not compile with #35627 |
PR description:
This PR adds 2D summary plots for data vs emulator comparison on L1T shower objects to the online DQM monitor and monitor client modules. There are 2 summary plots for each of the ALCT showers, CLCT showers, LCT combined showers, and EMTF showers. The plot setting follows the CSC TP plots in PR#36226.
At the moment shower objects are not implemented in CSC or EMTF firmwares. Emulation is used in the place of data in this PR and the setting will be updated to data once showers are available.
PR validation:
This PR is tested with 10k events in a Higgs to LLP to 4b sample, plot examples are available at link
The PR passed local unit tests and matrix tests. The standard code format is applied.
if this PR is a backport please specify the original PR and why you need to backport that PR:
N/A.