Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DQMOffline/Lumi zcounting backport of PR #40815 [CMSSW_13_0_X] #40874

Merged
merged 4 commits into from
Mar 1, 2023
Merged

DQMOffline/Lumi zcounting backport of PR #40815 [CMSSW_13_0_X] #40874

merged 4 commits into from
Mar 1, 2023

Conversation

davidwalter2
Copy link
Contributor

This is a backport of PR #40815
The backport is needed because we want the changes in DQMOffline to be active in the upcoming data taking period in 2023

david walter added 4 commits February 24, 2023 11:45
Incorporate improvements from LUM-21-001: Requirements on the inner a…
893ec23 
…nd outer track pT, |eta|, and dR are now added in the global muon requirement; The global muon efficiency is now measured using the merged standalone collection and using the outer track parameters; The standalone muon efficiency is measured using only tracks that are not muon seeded and a dR matching to an outer track is performed (instead of taking the reference).
Apply code formats
b3427cc
Replace deltaR by deltaR2 and int with bool
e79ac72
replace deltaR with deltaR2 also for trigger matching
ccaaaf3
@cmsbuild cmsbuild added this to the CMSSW_13_0_X milestone Feb 24, 2023
@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 24, 2023 •
edited
Loading

A new Pull Request was created by @davidwalter2 for CMSSW_13_0_X.

It involves the following packages:

  • DQMOffline/Lumi (dqm)

@emanueleusai, @cmsbuild, @syuvivida, @rvenditti, @micsucmed, @pmandrik can you please review it and eventually sign? Thanks.
@missirol, @rociovilar this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@davidwalter2 davidwalter2 changed the title Backport of PR #40815 into CMSSW_13_0_X DQMOffline/Lumi zcounting backport of PR #40815 [CMSSW_13_0_X] Feb 24, 2023
@emanueleusai
Copy link
Member

backport of #40815

@emanueleusai
Copy link
Member

please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fc9e4b/30917/summary.html
COMMIT: ccaaaf3
CMSSW: CMSSW_13_0_X_2023-02-26-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40874/30917/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

  • 20834.020834.0_TTbar_14TeV+2026D88/step2_TTbar_14TeV+2026D88.log
  • 20834.10320834.103_TTbar_14TeV+2026D88Aging3000/step2_TTbar_14TeV+2026D88Aging3000.log
  • 20834.2120834.21_TTbar_14TeV+2026D88_ProdLike/step2_TTbar_14TeV+2026D88_ProdLike.log
Expand to see more relval errors ...

Comparison Summary

Summary:

  • You potentially added 5 lines to the logs
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3556944
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3556916
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@emanueleusai
Copy link
Member

relvals timed out. Let's retest

@emanueleusai
Copy link
Member

please test

@perrotta
Copy link
Contributor

@emanueleusai those RelVal-Input relvals will keep failing, as they do in the IBs, until #40889 is not fixed.
Please make your review based on the other tests and comparisons for te time being

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fc9e4b/30937/summary.html
COMMIT: ccaaaf3
CMSSW: CMSSW_13_0_X_2023-02-27-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40874/30937/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

  • 20834.2120834.21_TTbar_14TeV+2026D88_ProdLike/step2_TTbar_14TeV+2026D88_ProdLike.log
  • 20834.020834.0_TTbar_14TeV+2026D88/step2_TTbar_14TeV+2026D88.log
  • 20834.10320834.103_TTbar_14TeV+2026D88Aging3000/step2_TTbar_14TeV+2026D88Aging3000.log
Expand to see more relval errors ...

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 11 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3557190
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3557159
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@emanueleusai
Copy link
Member

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 1, 2023

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (but tests are reportedly failing) and once validation in the development release cycle CMSSW_13_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Mar 1, 2023

+1

@perrotta
Copy link
Contributor

perrotta commented Mar 1, 2023

merge

@cmsbuild cmsbuild merged commit 7dd1ab1 into cms-sw:CMSSW_13_0_X Mar 1, 2023
@cmsbuild cmsbuild mentioned this pull request Mar 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport-ok dqm-approved fully-signed orp-approved tests-rejected
Projects
None yet
Milestone
CMSSW_13_0_X
Development

Successfully merging this pull request may close these issues.
4 participants
@davidwalter2 @cmsbuild @emanueleusai @perrotta