Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phase-2 GT interface update and slice test pattern writers #45606

Merged
merged 13 commits into from
Sep 11, 2024

Conversation

HaarigerHarald
Copy link

PR description:

This includes a small interface update specifically GTT sums and an update to the muon interface after #44498.

Additionally it contains the pattern writers for the slice tests, which were already successfully employed during GMT slice tests and will be used during GTT slice tests.

A minor addition of a pt multiplicity cut is also included.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 31, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45606/41099

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @HaarigerHarald for master.

It involves the following packages:

  • DataFormats/L1Trigger (l1)
  • L1Trigger/Phase2L1GT (l1, upgrade)

@aloeliger, @cmsbuild, @epalencia, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @dinyar, @eyigitba, @kreczko, @missirol, @mmusich, @rovere, @thomreis this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2024

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2024

Pull request #45606 was updated. @aloeliger, @cmsbuild, @epalencia, @srimanob, @subirsarkar can you please check and sign again.

@cmsbuild
Copy link
Contributor

Pull request #45606 was updated. @aloeliger, @cmsbuild, @epalencia, @srimanob, @subirsarkar can you please check and sign again.

@aloeliger
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-885051/41170/summary.html
COMMIT: 20188f2
CMSSW: CMSSW_14_2_X_2024-08-27-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45606/41170/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@aloeliger
Copy link
Contributor

+l1

@srimanob
Copy link
Contributor

@cmsbuild please test

Re-trigger the test after 2 weeks, to see failure comparison.

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-885051/41436/summary.html
COMMIT: 20188f2
CMSSW: CMSSW_14_2_X_2024-09-09-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45606/41436/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@srimanob
Copy link
Contributor

+Upgrade

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants