Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace CUDA with Alpaka wf in relval_2026.py #45980

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

AdrianoDee
Copy link
Contributor

PR description:

This PR proposes to replace the *.501 and *.502 wfs with the *.402 one in Alpaka for Phase2. This would also definitely solve #45332 (comment) removing the (deprecated) CUDA wfs.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 11, 2024

cms-bot internal usage

@AdrianoDee
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45980/41744

  • There are other open Pull requests which might conflict with changes you have proposed:

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @AdrianoDee for master.

It involves the following packages:

  • Configuration/PyReleaseValidation (upgrade, pdmv)

@AdrianoDee, @kskovpen, @miquork, @srimanob, @subirsarkar, @sunilUIET can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fabiocos, @makortel, @missirol, @slomeo this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@AdrianoDee
Copy link
Contributor Author

type bug-fix

@AdrianoDee
Copy link
Contributor Author

test parameters:

  • relval_opts = -w upgrade
  • workflows = 29634.402

@AdrianoDee
Copy link
Contributor Author

please abort

@AdrianoDee
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d7f68b/41462/summary.html
COMMIT: d098600
CMSSW: CMSSW_14_2_X_2024-09-11-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45980/41462/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d7f68b/41462/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d7f68b/41462/git-merge-result

Comparison Summary

Summary:

@AdrianoDee
Copy link
Contributor Author

+pdmv

@mmusich
Copy link
Contributor

mmusich commented Sep 16, 2024

@cms-sw/upgrade-l2 please take a look / sign

@srimanob
Copy link
Contributor

+Upgrade

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit e54f434 into cms-sw:master Sep 17, 2024
12 checks passed
@mandrenguyen
Copy link
Contributor

mandrenguyen commented Sep 17, 2024

@AdrianoDee There are *.501, *.502 failures in 14_1_X as well. Assuming this PR fixes those failures, can you prepare a backport?
Nevermind, I see there is one.

@AdrianoDee
Copy link
Contributor Author

@AdrianoDee There are *.501, *.502 failures in 14_1_X as well. Assuming this PR fixes those failures, can you prepare a backport? Nevermind, I see there is one.

@mandrenguyen actually you were right. I've opened this #46051 to fix the failures in 14_1_X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants