Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add variants to the phase-2 relval workflow running the HLT timing menu, up to step2 #46064

Merged
merged 3 commits into from
Sep 30, 2024

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Sep 19, 2024

PR description:

This is a follow-up to #45776 and adds a variant to the phase-2 HLT timing menu worklow using the alpaka and ticl_v5 modifiers. This should help in spotting issues such as #46060.

PR validation:

runTheMatrix.py --what upgrade -l 29634.750,29634.751,29634.752

runs fine.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 19, 2024

cms-bot internal usage

@mmusich mmusich force-pushed the mm_dev_timingPhase2HLT_alpaka branch from b76de8a to 2e99437 Compare September 19, 2024 18:06
@mmusich
Copy link
Contributor Author

mmusich commented Sep 19, 2024

test parameters:

  • relvals_opt = --what upgrade
  • workflows = 29634.751

@mmusich
Copy link
Contributor Author

mmusich commented Sep 19, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46064/41851

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich for master.

It involves the following packages:

  • Configuration/PyReleaseValidation (upgrade, pdmv)

@AdrianoDee, @kskovpen, @miquork, @srimanob, @subirsarkar, @sunilUIET can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fabiocos, @makortel, @missirol, @slomeo this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46064/41852

@cmsbuild
Copy link
Contributor

Pull request #46064 was updated. @AdrianoDee, @cmsbuild, @kskovpen, @miquork, @srimanob, @subirsarkar, @sunilUIET can you please check and sign again.

@mmusich
Copy link
Contributor Author

mmusich commented Sep 19, 2024

@cmsbuild, please test

@mmusich
Copy link
Contributor Author

mmusich commented Sep 19, 2024

I am expecting this round of tests to fail.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Pull request #46064 was updated. @AdrianoDee, @Moanwar, @cmsbuild, @kskovpen, @miquork, @srimanob, @subirsarkar, @sunilUIET can you please check and sign again.

@mmusich
Copy link
Contributor Author

mmusich commented Sep 26, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 36KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0e1a78/41758/summary.html
COMMIT: fb056d7
CMSSW: CMSSW_14_2_X_2024-09-25-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46064/41758/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@mmusich
Copy link
Contributor Author

mmusich commented Sep 26, 2024

@cms-sw/pdmv-l2 @cms-sw/upgrade-l2 please take a look at this, we'll need to be able to validate phase-2 HLT menu PRs.

@Moanwar
Copy link
Contributor

Moanwar commented Sep 26, 2024

+Upgrade

@AdrianoDee
Copy link
Contributor

+pdmv

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 26b7d52 into cms-sw:master Sep 30, 2024
12 checks passed
@mmusich mmusich deleted the mm_dev_timingPhase2HLT_alpaka branch September 30, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants