[NanoAOD] Add ParticleNet-based Muon ID #46153

jlidrych · 2024-09-30T11:34:10Z

PR description:

This PR adds ParticleNet-based Muon ID for NanoAODv15.
The feature was discussed during Muon POG meeting (23/09/2024) and it will be discussed during XPOG meeting (2/10/2024)

PR validation:

I've performed a local running test to see that the mva is loaded and nanoAOD is in fact produced.

cmsbuild · 2024-09-30T11:34:36Z

cms-bot internal usage

cmsbuild · 2024-09-30T11:36:05Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46153/41945

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46153/41945/code-format.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46153/41945/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2024-09-30T11:46:39Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46153/41946

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46153/41946/code-format.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46153/41946/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2024-09-30T12:12:32Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46153/41947

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46153/41947/code-format.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46153/41947/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2024-09-30T12:27:34Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46153/41948

cmsbuild · 2024-10-02T14:58:49Z

Pull request #46153 was updated. @cmsbuild, @ftorrresd, @hqucms, @jfernan2, @mandrenguyen can you please check and sign again.

hqucms · 2024-10-02T15:17:51Z

please test

cmsbuild · 2024-10-02T17:54:17Z

-1

Failed Tests: UnitTests RelVals RelVals-INPUT RelVals-NANO
Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b5c5cd/41894/summary.html
COMMIT: 50946a3
CMSSW: CMSSW_14_2_X_2024-10-02-1100/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46153/41894/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

@felicepantaleo ticl: Optimize calculation of Trackster time #46133

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b5c5cd/41894/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b5c5cd/41894/git-merge-result

Unit Tests

I found 1 errors in the following unit tests:

---> test test-das-selected-lumis had ERRORS

RelVals

140.023

----- Begin Fatal Exception 02-Oct-2024 18:26:57 CEST-----------------------
An exception of category 'FileInPathError' occurred while
   [0] Constructing the EventProcessor
Exception Message:
edm::FileInPath unable to find file PhysicsTools/PatAlgos/data/model.onnx anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46153/41894/CMSSW_14_2_X_2024-10-02-1100/poison:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46153/41894/CMSSW_14_2_X_2024-10-02-1100/src:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46153/41894/CMSSW_14_2_X_2024-10-02-1100/external/el8_amd64_gcc12/data:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02857/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_2_X_2024-10-02-1100/poison:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02857/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_2_X_2024-10-02-1100/src
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/matrix-results/140.023_RunZeroBias2022B
----- End Fatal Exception -------------------------------------------------

140.043

----- Begin Fatal Exception 02-Oct-2024 18:27:00 CEST-----------------------
An exception of category 'FileInPathError' occurred while
   [0] Constructing the EventProcessor
Exception Message:
edm::FileInPath unable to find file PhysicsTools/PatAlgos/data/model.onnx anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46153/41894/CMSSW_14_2_X_2024-10-02-1100/poison:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46153/41894/CMSSW_14_2_X_2024-10-02-1100/src:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46153/41894/CMSSW_14_2_X_2024-10-02-1100/external/el8_amd64_gcc12/data:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02857/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_2_X_2024-10-02-1100/poison:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02857/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_2_X_2024-10-02-1100/src
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/matrix-results/140.043_RunZeroBias2022C
----- End Fatal Exception -------------------------------------------------

140.063

----- Begin Fatal Exception 02-Oct-2024 18:27:05 CEST-----------------------
An exception of category 'FileInPathError' occurred while
   [0] Constructing the EventProcessor
Exception Message:
edm::FileInPath unable to find file PhysicsTools/PatAlgos/data/model.onnx anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46153/41894/CMSSW_14_2_X_2024-10-02-1100/poison:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46153/41894/CMSSW_14_2_X_2024-10-02-1100/src:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46153/41894/CMSSW_14_2_X_2024-10-02-1100/external/el8_amd64_gcc12/data:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02857/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_2_X_2024-10-02-1100/poison:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02857/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_2_X_2024-10-02-1100/src
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/matrix-results/140.063_RunZeroBias2022D
----- End Fatal Exception -------------------------------------------------

Expand to see more relval errors ...

RelVals-INPUT

2500.0012500.001_NANOmc106Xul16v2/step2_NANOmc106Xul16v2.log
2500.0022500.002_NANOmc106Xul17v2/step2_NANOmc106Xul17v2.log
2500.0032500.003_NANOmc106Xul18v2/step2_NANOmc106Xul18v2.log

Expand to see more relval errors ...

RelVals-NANO

2500.0012500.001_NANOmc106Xul16v2/step2_NANOmc106Xul16v2.log
2500.0022500.002_NANOmc106Xul17v2/step2_NANOmc106Xul17v2.log
2500.0032500.003_NANOmc106Xul18v2/step2_NANOmc106Xul18v2.log

Expand to see more relval errors ...

cmsbuild · 2024-10-02T19:05:34Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46153/42012

cmsbuild · 2024-10-02T19:05:58Z

Pull request #46153 was updated. @cmsbuild, @ftorrresd, @hqucms, @jfernan2, @mandrenguyen can you please check and sign again.

hqucms · 2024-10-02T19:30:36Z

please test

cmsbuild · 2024-10-02T22:09:44Z

-1

Failed Tests: RelVals RelVals-INPUT RelVals-NANO
Size: This PR adds an extra 28KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b5c5cd/41902/summary.html
COMMIT: b1a124e
CMSSW: CMSSW_14_2_X_2024-10-02-1100/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46153/41902/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b5c5cd/41902/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b5c5cd/41902/git-merge-result

RelVals

140.023

----- Begin Fatal Exception 02-Oct-2024 22:52:40 CEST-----------------------
An exception of category 'FileInPathError' occurred while
   [0] Constructing the EventProcessor
Exception Message:
edm::FileInPath unable to find file PhysicsTools/PatAlgos/data/model.onnx anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46153/41902/CMSSW_14_2_X_2024-10-02-1100/poison:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46153/41902/CMSSW_14_2_X_2024-10-02-1100/src:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46153/41902/CMSSW_14_2_X_2024-10-02-1100/external/el8_amd64_gcc12/data:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02857/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_2_X_2024-10-02-1100/poison:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02857/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_2_X_2024-10-02-1100/src
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/matrix-results/140.023_RunZeroBias2022B
----- End Fatal Exception -------------------------------------------------

140.043

----- Begin Fatal Exception 02-Oct-2024 22:52:43 CEST-----------------------
An exception of category 'FileInPathError' occurred while
   [0] Constructing the EventProcessor
Exception Message:
edm::FileInPath unable to find file PhysicsTools/PatAlgos/data/model.onnx anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46153/41902/CMSSW_14_2_X_2024-10-02-1100/poison:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46153/41902/CMSSW_14_2_X_2024-10-02-1100/src:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46153/41902/CMSSW_14_2_X_2024-10-02-1100/external/el8_amd64_gcc12/data:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02857/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_2_X_2024-10-02-1100/poison:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02857/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_2_X_2024-10-02-1100/src
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/matrix-results/140.043_RunZeroBias2022C
----- End Fatal Exception -------------------------------------------------

140.063

----- Begin Fatal Exception 02-Oct-2024 22:52:51 CEST-----------------------
An exception of category 'FileInPathError' occurred while
   [0] Constructing the EventProcessor
Exception Message:
edm::FileInPath unable to find file PhysicsTools/PatAlgos/data/model.onnx anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46153/41902/CMSSW_14_2_X_2024-10-02-1100/poison:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46153/41902/CMSSW_14_2_X_2024-10-02-1100/src:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46153/41902/CMSSW_14_2_X_2024-10-02-1100/external/el8_amd64_gcc12/data:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02857/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_2_X_2024-10-02-1100/poison:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02857/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_2_X_2024-10-02-1100/src
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/matrix-results/140.063_RunZeroBias2022D
----- End Fatal Exception -------------------------------------------------

Expand to see more relval errors ...

RelVals-INPUT

2500.0012500.001_NANOmc106Xul16v2/step2_NANOmc106Xul16v2.log
2500.0032500.003_NANOmc106Xul18v2/step2_NANOmc106Xul18v2.log
2500.0022500.002_NANOmc106Xul17v2/step2_NANOmc106Xul17v2.log

Expand to see more relval errors ...

RelVals-NANO

2500.0012500.001_NANOmc106Xul16v2/step2_NANOmc106Xul16v2.log
2500.0032500.003_NANOmc106Xul18v2/step2_NANOmc106Xul18v2.log
2500.0022500.002_NANOmc106Xul17v2/step2_NANOmc106Xul17v2.log

Expand to see more relval errors ...

hqucms · 2024-10-04T22:51:21Z

@jlidrych I reworked this PR in #46273. Let's continue the discussion there.

hqucms · 2024-10-29T23:44:53Z

please close

Superseded by #46273.

[NanoAOD] Add ParticleNet-based Muon ID (Rework of #46153)

jlidrych added 2 commits September 30, 2024 11:41

change in deep_helpers.cc

afcd787

PNet Muon Id implementation

cc55303

cmsbuild added this to the CMSSW_14_2_X milestone Sep 30, 2024

cmsbuild added reconstruction-pending pending-signatures tests-pending orp-pending code-checks-pending xpog-pending changes-dataformats labels Sep 30, 2024

cmsbuild added code-checks-rejected and removed code-checks-pending labels Sep 30, 2024

fix code-format

5a2a330

cmsbuild added code-checks-pending and removed code-checks-rejected labels Sep 30, 2024

cmsbuild added code-checks-rejected and removed code-checks-pending labels Sep 30, 2024

Fix code-checks error

0a7a6cb

cmsbuild added code-checks-pending and removed code-checks-rejected labels Sep 30, 2024

cmsbuild added code-checks-rejected and removed code-checks-pending labels Sep 30, 2024

Fix code-checks error, again

cd1c61c

cmsbuild added code-checks-pending and removed code-checks-rejected labels Sep 30, 2024

cmsbuild added the code-checks-approved label Oct 2, 2024

cmsbuild added tests-started and removed tests-pending labels Oct 2, 2024

cmsbuild added tests-rejected and removed tests-started labels Oct 2, 2024

Fix issue with path

b1a124e

cmsbuild added tests-pending code-checks-pending and removed tests-rejected code-checks-approved labels Oct 2, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 2, 2024

cmsbuild added tests-started and removed tests-pending labels Oct 2, 2024

cmsbuild added tests-rejected and removed tests-started labels Oct 2, 2024

This was referenced Oct 4, 2024

Add models for PNet MuonID (Rework of #17) cms-data/PhysicsTools-NanoAOD#18

Merged

[NanoAOD] Add ParticleNet-based Muon ID (Rework of #46153) #46273

Merged

cmsbuild mentioned this pull request Oct 7, 2024

VXBS For High Pt #46287

Merged

cmsbuild closed this Oct 29, 2024

cmsbuild added a commit that referenced this pull request Oct 31, 2024

Merge pull request #46273 from hqucms/xpog/PNetMuonID

55d7248

[NanoAOD] Add ParticleNet-based Muon ID (Rework of #46153)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[NanoAOD] Add ParticleNet-based Muon ID #46153

[NanoAOD] Add ParticleNet-based Muon ID #46153

jlidrych commented Sep 30, 2024

cmsbuild commented Sep 30, 2024 •

edited

Loading

cmsbuild commented Sep 30, 2024

cmsbuild commented Sep 30, 2024

cmsbuild commented Sep 30, 2024

cmsbuild commented Sep 30, 2024

cmsbuild commented Oct 2, 2024

hqucms commented Oct 2, 2024

cmsbuild commented Oct 2, 2024

cmsbuild commented Oct 2, 2024

cmsbuild commented Oct 2, 2024

hqucms commented Oct 2, 2024

cmsbuild commented Oct 2, 2024

hqucms commented Oct 4, 2024

hqucms commented Oct 29, 2024

[NanoAOD] Add ParticleNet-based Muon ID #46153

[NanoAOD] Add ParticleNet-based Muon ID #46153

Conversation

jlidrych commented Sep 30, 2024

PR description:

PR validation:

cmsbuild commented Sep 30, 2024 • edited Loading

cmsbuild commented Sep 30, 2024

cmsbuild commented Sep 30, 2024

cmsbuild commented Sep 30, 2024

cmsbuild commented Sep 30, 2024

cmsbuild commented Oct 2, 2024

hqucms commented Oct 2, 2024

cmsbuild commented Oct 2, 2024

Unit Tests

RelVals

RelVals-INPUT

RelVals-NANO

cmsbuild commented Oct 2, 2024

cmsbuild commented Oct 2, 2024

hqucms commented Oct 2, 2024

cmsbuild commented Oct 2, 2024

RelVals

RelVals-INPUT

RelVals-NANO

hqucms commented Oct 4, 2024

hqucms commented Oct 29, 2024

cmsbuild commented Sep 30, 2024 •

edited

Loading