Several improvements to L1 tracking code #46360

tomalin · 2024-10-12T09:54:50Z

PR description:

This consists of several improvements from the Phase 2 L1 tracking group.

"combined" versions of the prompt & displaced tracking are now run by default, corresponding to the current firmware choice.
Serious bugs were fixed in the duplicate track removal. In addition, dependencies of the "combined module" version of the duplicate removal "wiring map" on the older non-combined module have been removed.
The L1 Track Quality variable is digitized according to the latest agreement.
The tracking performance plotting ROOT macro L1TrackNtupleMaker.C now prints both fake track rate and duplicate track rate in its summary printout.
For the HYBRID_NEWKF version of the L1 tracking, which corresponds to FW, but is not the current default for L1 trigger studies, the Kalman Filter Track fit EDProducers have been significantly rearranged, with the advantage that the output TTTrack collection is now created from the end of the chain, and so includes the TrackQuality variable.
Truncation has been reduced in the MatchProcessor module.
The TrackletProcessorDisplaced.cc code has been shortened by removing unnecessary code.

This PR does not significantly change the displaced L1 track performance, as is shown in the talk https://indico.cern.ch/event/1473530/contributions/6203794/attachments/2957687/5201212/Oct30_IanPRcombModulesQA_SeanPRgetMapCPUImprov.pdf .

IMPORTANT: The changes to the duplicate track removal algorithm in this PR are dependent on the changes in cms-data from this PR cms-data/L1Trigger-TrackFindingTracklet#6 , so the two PRs must be introduced into the same version of CMSSW.

cmsbuild · 2024-10-12T09:55:15Z

cms-bot internal usage

cmsbuild · 2024-10-12T09:57:39Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46360/42200

Found files with invalid states:
- L1Trigger/TrackFindingTracklet/data/memorymodules_hourglassExtendedCombined.dat:
  - Added: c53200f
  - Deleted: 35c77d9
- L1Trigger/TrackFindingTracklet/data/wires_hourglassExtendedCombined.dat:
  - Added: c53200f
  - Deleted: 35c77d9
- L1Trigger/TrackFindingTracklet/data/processingmodules_hourglassExtendedCombined.dat:
  - Added: c53200f
  - Deleted: 35c77d9
- L1Trigger/TrackFindingTracklet/data/wires_hourglassExtendedAllCombined.dat:
  - Added: c53200f
  - Deleted: 35c77d9
- L1Trigger/TrackFindingTracklet/data/calcNumDTCLinks.txt:
  - Added: c53200f
  - Deleted: 35c77d9
- L1Trigger/TrackFindingTracklet/data/fitpattern.txt:
  - Added: c53200f
  - Deleted: 35c77d9
- L1Trigger/TrackFindingTracklet/data/processingmodules_hourglassExtendedAllCombined.dat:
  - Added: c53200f
  - Deleted: 35c77d9
- L1Trigger/TrackFindingTracklet/data/memorymodules_hourglassExtendedAllCombined.dat:
  - Added: c53200f
  - Deleted: 35c77d9
There are other open Pull requests which might conflict with changes you have proposed:
- File L1Trigger/TrackFindingTracklet/plugins/L1FPGATrackProducer.cc modified in PR(s): Displaced vertexing gbdt #45672
- File L1Trigger/TrackFindingTracklet/python/Producer_cfi.py modified in PR(s): L1Trk reco enabling CheckHistory by default #43690, Displaced vertexing gbdt #45672
- File L1Trigger/TrackFindingTracklet/python/l1tTTTracksFromTrackletEmulation_cfi.py modified in PR(s): Displaced vertexing gbdt #45672
- File L1Trigger/TrackFindingTracklet/src/TrackletLUT.cc modified in PR(s): fix c++20 compilation errors in L1Trigger/TrackFindingTracklet #43673

cmsbuild · 2024-10-12T09:58:02Z

A new Pull Request was created by @tomalin for master.

It involves the following packages:

L1Trigger/TrackFindingTracklet (l1)
L1Trigger/TrackerDTC (upgrade, l1)
L1Trigger/TrackerTFP (l1)

@Moanwar, @aloeliger, @cmsbuild, @epalencia, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @erikbutz, @missirol, @mmusich, @skinnari this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

cmsbuild · 2024-10-14T08:02:45Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46360/42206

Found files with invalid states:
- L1Trigger/TrackFindingTracklet/data/memorymodules_hourglassExtendedCombined.dat:
  - Added: c53200f
  - Deleted: 35c77d9
- L1Trigger/TrackFindingTracklet/data/wires_hourglassExtendedCombined.dat:
  - Added: c53200f
  - Deleted: 35c77d9
- L1Trigger/TrackFindingTracklet/data/processingmodules_hourglassExtendedCombined.dat:
  - Added: c53200f
  - Deleted: 35c77d9
- L1Trigger/TrackFindingTracklet/data/wires_hourglassExtendedAllCombined.dat:
  - Added: c53200f
  - Deleted: 35c77d9
- L1Trigger/TrackFindingTracklet/data/calcNumDTCLinks.txt:
  - Added: c53200f
  - Deleted: 35c77d9
- L1Trigger/TrackFindingTracklet/data/fitpattern.txt:
  - Added: c53200f
  - Deleted: 35c77d9
- L1Trigger/TrackFindingTracklet/data/processingmodules_hourglassExtendedAllCombined.dat:
  - Added: c53200f
  - Deleted: 35c77d9
- L1Trigger/TrackFindingTracklet/data/memorymodules_hourglassExtendedAllCombined.dat:
  - Added: c53200f
  - Deleted: 35c77d9
There are other open Pull requests which might conflict with changes you have proposed:
- File L1Trigger/TrackFindingTracklet/plugins/L1FPGATrackProducer.cc modified in PR(s): Displaced vertexing gbdt #45672
- File L1Trigger/TrackFindingTracklet/python/Producer_cfi.py modified in PR(s): L1Trk reco enabling CheckHistory by default #43690, Displaced vertexing gbdt #45672
- File L1Trigger/TrackFindingTracklet/python/l1tTTTracksFromTrackletEmulation_cfi.py modified in PR(s): Displaced vertexing gbdt #45672
- File L1Trigger/TrackFindingTracklet/src/TrackletLUT.cc modified in PR(s): fix c++20 compilation errors in L1Trigger/TrackFindingTracklet #43673

cmsbuild · 2024-10-14T08:03:06Z

Pull request #46360 was updated. @Moanwar, @aloeliger, @cmsbuild, @epalencia, @srimanob, @subirsarkar can you please check and sign again.

srimanob · 2024-10-14T09:27:23Z

@cmsbuild please test

cmsbuild · 2024-10-14T11:29:05Z

-1

Failed Tests: RelVals
Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5b63f8/42150/summary.html
COMMIT: 021af0d
CMSSW: CMSSW_14_2_X_2024-10-13-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46360/42150/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

29696.0

----- Begin Fatal Exception 14-Oct-2024 12:25:57 CEST-----------------------
An exception of category 'ConfigFileReadError' occurred while
   [0] Processing the python configuration file named step2_DIGI_L1TrackTrigger_L1_L1P2GT_DIGI2RAW_HLT.py
Exception Message:
 unknown python problem occurred.
RuntimeError: An exception of category 'FileInPathError' occurred.
Exception Message:
edm::FileInPath unable to find file L1Trigger/TrackFindingTracklet/data/memorymodules_hourglassExtendedAllCombined.dat anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46360/42150/CMSSW_14_2_X_2024-10-13-2300/poison:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46360/42150/CMSSW_14_2_X_2024-10-13-2300/src:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46360/42150/CMSSW_14_2_X_2024-10-13-2300/external/el8_amd64_gcc12/data:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02859/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_2_X_2024-10-13-2300/poison:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02859/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_2_X_2024-10-13-2300/src:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02859/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_2_X_2024-10-13-2300/external/el8_amd64_gcc12/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/matrix-results/29696.0_CloseByPGun_CE_E_Front_120um+2026D110


At:
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02859/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_2_X_2024-10-13-2300/src/FWCore/ParameterSet/python/Types.py(1001): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02859/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_2_X_2024-10-13-2300/src/FWCore/ParameterSet/python/Mixins.py(397): insertContentsInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02859/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_2_X_2024-10-13-2300/src/FWCore/ParameterSet/python/Mixins.py(532): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02859/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_2_X_2024-10-13-2300/src/FWCore/ParameterSet/python/Modules.py(161): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02859/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_2_X_2024-10-13-2300/src/FWCore/ParameterSet/python/Config.py(1217): _insertManyInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02859/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_2_X_2024-10-13-2300/src/FWCore/ParameterSet/python/Config.py(1490): fillProcessDesc
  <string>(2): <module>

----- End Fatal Exception -------------------------------------------------

29700.0

----- Begin Fatal Exception 14-Oct-2024 12:26:46 CEST-----------------------
An exception of category 'ConfigFileReadError' occurred while
   [0] Processing the python configuration file named step2_DIGI_L1TrackTrigger_L1_L1P2GT_DIGI2RAW_HLT.py
Exception Message:
 unknown python problem occurred.
RuntimeError: An exception of category 'FileInPathError' occurred.
Exception Message:
edm::FileInPath unable to find file L1Trigger/TrackFindingTracklet/data/memorymodules_hourglassExtendedAllCombined.dat anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46360/42150/CMSSW_14_2_X_2024-10-13-2300/poison:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46360/42150/CMSSW_14_2_X_2024-10-13-2300/src:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46360/42150/CMSSW_14_2_X_2024-10-13-2300/external/el8_amd64_gcc12/data:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02859/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_2_X_2024-10-13-2300/poison:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02859/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_2_X_2024-10-13-2300/src:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02859/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_2_X_2024-10-13-2300/external/el8_amd64_gcc12/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/matrix-results/29700.0_CloseByPGun_CE_H_Coarse_Scint+2026D110


At:
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02859/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_2_X_2024-10-13-2300/src/FWCore/ParameterSet/python/Types.py(1001): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02859/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_2_X_2024-10-13-2300/src/FWCore/ParameterSet/python/Mixins.py(397): insertContentsInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02859/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_2_X_2024-10-13-2300/src/FWCore/ParameterSet/python/Mixins.py(532): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02859/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_2_X_2024-10-13-2300/src/FWCore/ParameterSet/python/Modules.py(161): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02859/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_2_X_2024-10-13-2300/src/FWCore/ParameterSet/python/Config.py(1217): _insertManyInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02859/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_2_X_2024-10-13-2300/src/FWCore/ParameterSet/python/Config.py(1490): fillProcessDesc
  <string>(2): <module>

----- End Fatal Exception -------------------------------------------------

29634.75

----- Begin Fatal Exception 14-Oct-2024 12:29:24 CEST-----------------------
An exception of category 'ConfigFileReadError' occurred while
   [0] Processing the python configuration file named step2_DIGI_L1TrackTrigger_L1_L1P2GT_DIGI2RAW_HLT.py
Exception Message:
 unknown python problem occurred.
RuntimeError: An exception of category 'FileInPathError' occurred.
Exception Message:
edm::FileInPath unable to find file L1Trigger/TrackFindingTracklet/data/memorymodules_hourglassExtendedAllCombined.dat anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46360/42150/CMSSW_14_2_X_2024-10-13-2300/poison:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46360/42150/CMSSW_14_2_X_2024-10-13-2300/src:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46360/42150/CMSSW_14_2_X_2024-10-13-2300/external/el8_amd64_gcc12/data:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02859/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_2_X_2024-10-13-2300/poison:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02859/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_2_X_2024-10-13-2300/src:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02859/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_2_X_2024-10-13-2300/external/el8_amd64_gcc12/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/matrix-results/29634.75_TTbar_14TeV+2026D110_HLT75e33Timing


At:
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02859/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_2_X_2024-10-13-2300/src/FWCore/ParameterSet/python/Types.py(1001): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02859/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_2_X_2024-10-13-2300/src/FWCore/ParameterSet/python/Mixins.py(397): insertContentsInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02859/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_2_X_2024-10-13-2300/src/FWCore/ParameterSet/python/Mixins.py(532): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02859/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_2_X_2024-10-13-2300/src/FWCore/ParameterSet/python/Modules.py(161): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02859/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_2_X_2024-10-13-2300/src/FWCore/ParameterSet/python/Config.py(1217): _insertManyInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02859/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_2_X_2024-10-13-2300/src/FWCore/ParameterSet/python/Config.py(1490): fillProcessDesc
  <string>(2): <module>

----- End Fatal Exception -------------------------------------------------

Expand to see more relval errors ...

srimanob · 2024-10-14T11:37:26Z

test parameters:

pull_request = Extended wiring with all combined modules cms-data/L1Trigger-TrackFindingTracklet#6

L1Trigger/TrackFindingTracklet/interface/Settings.h

cmsbuild · 2024-10-29T16:14:13Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46360/42410

Found files with invalid states:
- L1Trigger/TrackFindingTracklet/data/memorymodules_hourglassExtendedCombined.dat:
  - Added: 4ac2939
  - Deleted: 3b7a13c
- L1Trigger/TrackFindingTracklet/data/wires_hourglassExtendedCombined.dat:
  - Added: 4ac2939
  - Deleted: 3b7a13c
- L1Trigger/TrackFindingTracklet/data/processingmodules_hourglassExtendedCombined.dat:
  - Added: 4ac2939
  - Deleted: 3b7a13c
- L1Trigger/TrackFindingTracklet/data/wires_hourglassExtendedAllCombined.dat:
  - Added: 4ac2939
  - Deleted: 3b7a13c
- L1Trigger/TrackFindingTracklet/data/calcNumDTCLinks.txt:
  - Added: 4ac2939
  - Deleted: 3b7a13c
- L1Trigger/TrackFindingTracklet/data/fitpattern.txt:
  - Added: 4ac2939
  - Deleted: 3b7a13c
- L1Trigger/TrackFindingTracklet/data/processingmodules_hourglassExtendedAllCombined.dat:
  - Added: 4ac2939
  - Deleted: 3b7a13c
- L1Trigger/TrackFindingTracklet/data/memorymodules_hourglassExtendedAllCombined.dat:
  - Added: 4ac2939
  - Deleted: 3b7a13c
There are other open Pull requests which might conflict with changes you have proposed:
- File L1Trigger/TrackFindingTracklet/plugins/L1FPGATrackProducer.cc modified in PR(s): Displaced vertexing gbdt #45672
- File L1Trigger/TrackFindingTracklet/python/Producer_cfi.py modified in PR(s): L1Trk reco enabling CheckHistory by default #43690, Displaced vertexing gbdt #45672
- File L1Trigger/TrackFindingTracklet/python/l1tTTTracksFromTrackletEmulation_cfi.py modified in PR(s): Displaced vertexing gbdt #45672
- File L1Trigger/TrackFindingTracklet/src/TrackletLUT.cc modified in PR(s): fix c++20 compilation errors in L1Trigger/TrackFindingTracklet #43673
- File L1Trigger/TrackFindingTracklet/test/L1TrackNtupleMaker.cc modified in PR(s): Displaced vertexing gbdt #45672

cmsbuild · 2024-10-29T16:14:38Z

Pull request #46360 was updated. @Moanwar, @aloeliger, @cmsbuild, @epalencia, @srimanob, @subirsarkar can you please check and sign again.

L1Trigger/TrackFindingTracklet/interface/VMRouterCM.h

cmsbuild · 2024-10-29T16:54:05Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46360/42412

Found files with invalid states:
- L1Trigger/TrackFindingTracklet/data/memorymodules_hourglassExtendedCombined.dat:
  - Added: 4ac2939
  - Deleted: 3b7a13c
- L1Trigger/TrackFindingTracklet/data/wires_hourglassExtendedCombined.dat:
  - Added: 4ac2939
  - Deleted: 3b7a13c
- L1Trigger/TrackFindingTracklet/data/processingmodules_hourglassExtendedCombined.dat:
  - Added: 4ac2939
  - Deleted: 3b7a13c
- L1Trigger/TrackFindingTracklet/data/wires_hourglassExtendedAllCombined.dat:
  - Added: 4ac2939
  - Deleted: 3b7a13c
- L1Trigger/TrackFindingTracklet/data/calcNumDTCLinks.txt:
  - Added: 4ac2939
  - Deleted: 3b7a13c
- L1Trigger/TrackFindingTracklet/data/fitpattern.txt:
  - Added: 4ac2939
  - Deleted: 3b7a13c
- L1Trigger/TrackFindingTracklet/data/processingmodules_hourglassExtendedAllCombined.dat:
  - Added: 4ac2939
  - Deleted: 3b7a13c
- L1Trigger/TrackFindingTracklet/data/memorymodules_hourglassExtendedAllCombined.dat:
  - Added: 4ac2939
  - Deleted: 3b7a13c
There are other open Pull requests which might conflict with changes you have proposed:
- File L1Trigger/TrackFindingTracklet/plugins/L1FPGATrackProducer.cc modified in PR(s): Displaced vertexing gbdt #45672
- File L1Trigger/TrackFindingTracklet/python/Producer_cfi.py modified in PR(s): L1Trk reco enabling CheckHistory by default #43690, Displaced vertexing gbdt #45672
- File L1Trigger/TrackFindingTracklet/python/l1tTTTracksFromTrackletEmulation_cfi.py modified in PR(s): Displaced vertexing gbdt #45672
- File L1Trigger/TrackFindingTracklet/src/TrackletLUT.cc modified in PR(s): fix c++20 compilation errors in L1Trigger/TrackFindingTracklet #43673
- File L1Trigger/TrackFindingTracklet/test/L1TrackNtupleMaker.cc modified in PR(s): Displaced vertexing gbdt #45672

cmsbuild · 2024-10-29T16:54:33Z

Pull request #46360 was updated. @Moanwar, @aloeliger, @cmsbuild, @epalencia, @srimanob, @subirsarkar can you please check and sign again.

cmsbuild · 2024-10-29T17:10:42Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46360/42413

Found files with invalid states:
- L1Trigger/TrackFindingTracklet/data/memorymodules_hourglassExtendedCombined.dat:
  - Added: 4ac2939
  - Deleted: 3b7a13c
- L1Trigger/TrackFindingTracklet/data/wires_hourglassExtendedCombined.dat:
  - Added: 4ac2939
  - Deleted: 3b7a13c
- L1Trigger/TrackFindingTracklet/data/processingmodules_hourglassExtendedCombined.dat:
  - Added: 4ac2939
  - Deleted: 3b7a13c
- L1Trigger/TrackFindingTracklet/data/wires_hourglassExtendedAllCombined.dat:
  - Added: 4ac2939
  - Deleted: 3b7a13c
- L1Trigger/TrackFindingTracklet/data/calcNumDTCLinks.txt:
  - Added: 4ac2939
  - Deleted: 3b7a13c
- L1Trigger/TrackFindingTracklet/data/fitpattern.txt:
  - Added: 4ac2939
  - Deleted: 3b7a13c
- L1Trigger/TrackFindingTracklet/data/processingmodules_hourglassExtendedAllCombined.dat:
  - Added: 4ac2939
  - Deleted: 3b7a13c
- L1Trigger/TrackFindingTracklet/data/memorymodules_hourglassExtendedAllCombined.dat:
  - Added: 4ac2939
  - Deleted: 3b7a13c
There are other open Pull requests which might conflict with changes you have proposed:
- File L1Trigger/TrackFindingTracklet/plugins/L1FPGATrackProducer.cc modified in PR(s): Displaced vertexing gbdt #45672
- File L1Trigger/TrackFindingTracklet/python/Producer_cfi.py modified in PR(s): L1Trk reco enabling CheckHistory by default #43690, Displaced vertexing gbdt #45672
- File L1Trigger/TrackFindingTracklet/python/l1tTTTracksFromTrackletEmulation_cfi.py modified in PR(s): Displaced vertexing gbdt #45672
- File L1Trigger/TrackFindingTracklet/src/TrackletLUT.cc modified in PR(s): fix c++20 compilation errors in L1Trigger/TrackFindingTracklet #43673
- File L1Trigger/TrackFindingTracklet/test/L1TrackNtupleMaker.cc modified in PR(s): Displaced vertexing gbdt #45672

cmsbuild · 2024-10-29T17:11:05Z

Pull request #46360 was updated. @Moanwar, @aloeliger, @cmsbuild, @epalencia, @srimanob, @subirsarkar can you please check and sign again.

srimanob · 2024-11-02T17:53:16Z

@cmsbuild please test

cmsbuild · 2024-11-02T21:52:08Z

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5b63f8/42562/summary.html
COMMIT: 8c1d039
CMSSW: CMSSW_14_2_X_2024-11-02-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46360/42562/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5b63f8/42562/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5b63f8/42562/git-merge-result

Comparison Summary

Summary:

You potentially added 14 lines to the logs
Reco comparison results: 13 differences found in the comparisons
DQMHistoTests: Total files compared: 46
DQMHistoTests: Total histograms compared: 3569567
DQMHistoTests: Total failures: 813
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 3568733
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.008 KiB( 45 files compared)
DQMHistoSizes: changed ( 140.56 ): 0.004 KiB MessageLogger/Errors
DQMHistoSizes: changed ( 140.56 ): 0.004 KiB MessageLogger/Warnings
Checked 201 log files, 171 edm output root files, 46 DQM output files
TriggerResults: found differences in 4 / 44 workflows

cmsbuild added this to the CMSSW_14_2_X milestone Oct 12, 2024

cmsbuild added l1-pending pending-signatures tests-pending orp-pending upgrade-pending code-checks-pending trk labels Oct 12, 2024

tomalin mentioned this pull request Oct 12, 2024

Several improvements to L1 tracking code #45974

Closed

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 12, 2024

tomalin mentioned this pull request Oct 12, 2024

Extended wiring with all combined modules cms-data/L1Trigger-TrackFindingTracklet#6

Open

cmsbuild added code-checks-pending and removed code-checks-approved labels Oct 14, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 14, 2024

cmsbuild added tests-started and removed tests-pending labels Oct 14, 2024

cmsbuild added tests-rejected and removed tests-started labels Oct 14, 2024

cmsbuild added the requires-external label Oct 14, 2024

cmsbuild mentioned this pull request Oct 16, 2024

[LLVM Analyzer][L1] Cleanup LLVM analyzer warnings #46411

Merged

cmsbuild added code-checks-pending and removed code-checks-approved labels Oct 29, 2024

Dr15Jones reviewed Oct 29, 2024

View reviewed changes

L1Trigger/TrackFindingTracklet/interface/Settings.h Outdated Show resolved Hide resolved

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 29, 2024

Dr15Jones reviewed Oct 29, 2024

View reviewed changes

L1Trigger/TrackFindingTracklet/interface/VMRouterCM.h Show resolved Hide resolved

Tidied functions Settings::layersDisksDup...

52d3924

cmsbuild added code-checks-pending and removed code-checks-approved labels Oct 29, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 29, 2024

Avoided copy of vector

8c1d039

cmsbuild added code-checks-pending and removed code-checks-approved labels Oct 29, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 29, 2024

tomalin marked this pull request as ready for review October 31, 2024 08:48

cmsbuild mentioned this pull request Nov 1, 2024

Rename Phase-2 "2026" geometries and workflows to "Run4" #46582

Merged

cmsbuild added tests-started and removed tests-pending labels Nov 2, 2024

cmsbuild added tests-approved and removed tests-started labels Nov 2, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Several improvements to L1 tracking code #46360

Several improvements to L1 tracking code #46360

tomalin commented Oct 12, 2024 •

edited

Loading

cmsbuild commented Oct 12, 2024 •

edited

Loading

cmsbuild commented Oct 12, 2024

cmsbuild commented Oct 12, 2024

cmsbuild commented Oct 14, 2024

cmsbuild commented Oct 14, 2024

srimanob commented Oct 14, 2024

cmsbuild commented Oct 14, 2024

srimanob commented Oct 14, 2024

cmsbuild commented Oct 29, 2024

cmsbuild commented Oct 29, 2024

cmsbuild commented Oct 29, 2024

cmsbuild commented Oct 29, 2024

cmsbuild commented Oct 29, 2024

cmsbuild commented Oct 29, 2024

srimanob commented Nov 2, 2024

cmsbuild commented Nov 2, 2024

Several improvements to L1 tracking code #46360

Are you sure you want to change the base?

Several improvements to L1 tracking code #46360

Conversation

tomalin commented Oct 12, 2024 • edited Loading

PR description:

cmsbuild commented Oct 12, 2024 • edited Loading

cmsbuild commented Oct 12, 2024

cmsbuild commented Oct 12, 2024

cmsbuild commented Oct 14, 2024

cmsbuild commented Oct 14, 2024

srimanob commented Oct 14, 2024

cmsbuild commented Oct 14, 2024

RelVals

srimanob commented Oct 14, 2024

cmsbuild commented Oct 29, 2024

cmsbuild commented Oct 29, 2024

cmsbuild commented Oct 29, 2024

cmsbuild commented Oct 29, 2024

cmsbuild commented Oct 29, 2024

cmsbuild commented Oct 29, 2024

srimanob commented Nov 2, 2024

cmsbuild commented Nov 2, 2024

Comparison Summary

tomalin commented Oct 12, 2024 •

edited

Loading

cmsbuild commented Oct 12, 2024 •

edited

Loading