Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Several improvements to L1 tracking code #46360

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Several improvements to L1 tracking code #46360

wants to merge 12 commits into from

Commits on Oct 29, 2024

  1. squashed commits since last PR to central CMSSW

    @tomalin
    tomalin committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    5a64fd1 View commit details
    Browse the repository at this point in the history

  2. auto format

    @tomalin
    tomalin committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    daca4ab View commit details
    Browse the repository at this point in the history

  3. auto code format

    @tomalin
    tomalin committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    1424f9e View commit details
    Browse the repository at this point in the history

  4. Add truncation in TrackletProcessorDisplaced (#293) 

    * include truncation in TrackletProcessorDisplaced

* code formatting

* include separate truncation for TP and TPD
    @cgsavard @tomalin
    cgsavard authored and tomalin committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    1dfc149 View commit details
    Browse the repository at this point in the history

  5. All-combined extended wiring (#292) 

    * Initial commit

* Separated ivmte and bins, but not correct yet

* Allow combined_ to be set for extended tracking.

* Logic for bins updated

* Revert lutwidthtab_ and use lutwidthtabextended_ for extended tracking.

* Set ivmte to zero by default and revert change to old VMRouter.

* Updated assert.

* Initialize LUTs from VMRouter.

* Use LUT values from VMRouter for triplet seeds.

* Added stubposition and made vmstubmem a vector of vectors.

* Added a combined flag to addVMStub.

* Use stubposition to get lutwidth.

* Skip disk 2S stubs only for pair seeds.

* Added some comments.

* Added assert on melutOld.

* Initialize in same order as declared in header file.

* Code format.

* Added method to return nbits_.

* Removed magic numbers.

* Added comments.

* Use new wiring with all combined modules.

* Temporarily added data directory from here:
https://github.com/aehart/L1Trigger-TrackFindingTracklet/tree/new_extended_wiring

---------

Co-authored-by: Jannicke Pearkes <[email protected]>
    @aehart @jpearkes @tomalin
    2 people authored and tomalin committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    4ac2939 View commit details
    Browse the repository at this point in the history

  6. Removed data directory as should not go into CMSSW

    @tomalin
    tomalin committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    3b7a13c View commit details
    Browse the repository at this point in the history

  7. style change

    @tomalin
    tomalin committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    1847f89 View commit details
    Browse the repository at this point in the history

  8. Fix GlobalTag problem

    @tomalin
    tomalin committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    107593e View commit details
    Browse the repository at this point in the history

  9. Clean up TrackletProcessorDisplaced (#294) 

    * clean up use of layerdisk and seed

* remove unnecessary and redundant code

* remove more redundant code

* clean up some bit operation logic

* more clean-up and additional checks added

* more clean up and add comments

* fixing merge conflicts after TPD truncation added

* remove additional rz check, fix for loop counter bug

* include combined flag in VMRtable

* minor PR comments

* remove more useless code
    @cgsavard @tomalin
    cgsavard authored and tomalin committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    1cf59ed View commit details
    Browse the repository at this point in the history

  10. scram b code-format with latest CMSSW version (#295) 

    Merging as trivial code-format change.
    @tomalin
    tomalin committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    b39c116 View commit details
    Browse the repository at this point in the history

  11. Tidied functions Settings::layersDisksDup...

    @tomalin
    tomalin committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    52d3924 View commit details
    Browse the repository at this point in the history

  12. Avoided copy of vector

    @tomalin
    tomalin committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    8c1d039 View commit details
    Browse the repository at this point in the history