On-hold flag and celery task for applicationstatus updates. #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New model TimeFlags has been added. Celery task to run once a day, to check the applications which has status set to more_information or on_hold. Based on UCD-25, either more the application to on_hold or reject them.
dhvander
reviewed
Jul 19, 2024
| @@ -22,4 +22,8 @@ | |||
| "task": "request_a_govuk_domain.request.tasks.check_email_failure_and_notify", | |||
| "schedule": crontab(minute="*/1"), | |||
| }, | |||
| "application-status-checker": { | |||
| "task": "request_a_govuk_domain.request.tasks.check_application_status", | |||
| "schedule": crontab(hour="0"), | |||
There was a problem hiding this comment.
I think you need to set the minute=0 otherwise it will run every minute at 0 hrs
There was a problem hiding this comment.
I think you need to set the minute=0 otherwise it will run every minute at 0 hrs
hour=0, doing it once a day at midnight. But will ask Robert on Monday.
dhvander
reviewed
Jul 19, 2024
| model = TimeFlag | ||
|
|
||
| def has_add_permission(self, request): | ||
| if self.model.objects.count() >= MAX_OBJECTS: |
There was a problem hiding this comment.
This should be False for any user as we do not want to add more entries?
There was a problem hiding this comment.
Maybe we will need a seed script?
There was a problem hiding this comment.
Maybe we will need a seed script?
up for discussion with Robert/Jim/Max I guess.
There was a problem hiding this comment.
This should be False for any user as we do not want to add more entries?
Done
dhvander
reviewed
Jul 19, 2024
dhvander
reviewed
Jul 19, 2024
Need more work, parking for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New model TimeFlags has been added.
Celery task to run once a day, to check the applications which has status set to more_information or on_hold. Based on UCD-25, either move the application to on_hold or reject them.