test: Move from CDP to BiDi #1761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is due to cockpit-project/cockpit#20862 . We use c-c-terminal in serialConsole.jsx, so we need to follow suit here. |
|
Fixed in #1762, rebased on that. |
21 tasks
|
OK, rest are flakes and pixel refs |
|
Applying the pixel test noise |
|
This testVSock failure is rather persistent, I'll take a look It's a naughty cockpit-project/bots#4915 which doesn't match any more, this needs fixing in the bidi driver: cockpit-project/cockpit#20883 |
See cockpit-project/cockpit#20832 Explicitly add a "glob" devDependency to follow suit with cockpit-project/cockpit@680decc155a It was previously used implicitly through a transient dependency of something else, but our esbuild po-plugin uses it explicitly. This causes some minor pixel test noise, adjust the references.
|
That was the last one of ours! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See cockpit-project/cockpit#20832
Explicitly add a "glob" devDependency to follow suit with
cockpit-project/cockpit@680decc155a
It was previously used implicitly through a transient dependency of
something else, but our esbuild po-plugin uses it explicitly.
This causes some minor pixel test noise, adjust the references.