fix disabled button check #1831
Conversation
|
I am honestly confused... how does tagging work? |
test/check-application
Outdated
| b.click("#containers-images tr:contains('my-busybox') td.pf-v5-c-table__toggle button") | ||
| b.click(f"#containers-images tr:contains('{second_tag}') td.pf-v5-c-table__toggle button") |
There was a problem hiding this comment.
This isn't a "fix" in the sense that the old behaviour was wrong. The original code checks that adding a second tag to an existing image correctly gets picked up by the UI and shown as "additional tag" names in the original image info.
You are welcome to add code which checks that the new tag also appears as an image by itself (and then also shows my-busybox as alternative tag name), but let's please keep that check.
There was a problem hiding this comment.
I see, my bad. I'll revert this then
test/check-application
Outdated
| b.wait_visible(".pf-v5-c-modal-box__footer #create-image-create-run-btn:not(:disabled)") | ||
| b.wait_visible(".pf-v5-c-modal-box__footer #create-image-create-run-btn:disabled") |
There was a problem hiding this comment.
The old code indeed looks wrong. However, two lines down the test already waits for the button to be aria-disabled, which looks redundant. One of these two is enough?
Test checks if a warning is displayed therefore create button should be disabled.
https://cockpit-logs.us-east-1.linodeobjects.com/pull-1821-bfa093ee-20240819-082934-debian-testing/log.html#10-2