DNM: clusterversion: set DevBranch=false #138852
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=373d9101a12edc3847d2fb6ae78e3adcfb4ca41e&v=4){kind=avatar}
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
celiala
force-pushed
the
DNM.set-devBranch-false
branch
4 times, most recently
from
155f2bd to
59b84af
Compare
|
|
This draft against `master` is solely to iron out CI failures ahead of next week's branch cut. This should NOT be merged into `master` (but rather redirected and merged onto `release-25.1` as soon as we do next week's branch cut. Release note: None Epic: None Release justification: release-process-only change.
celiala
force-pushed
the
DNM.set-devBranch-false
branch
from
59b84af to
c876573
Compare
|
blathers backport release-25.1 |
|
this has been backported to release-25.1. draft PR against master can now be closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This draft against
masteris solely to iron out CI failures ahead of next week's branch cut.This should NOT be merged into
master(but rather redirected and merged ontorelease-25.1as soon as we do next week's branch cut.Runbook:
dev generate10000MM.dwithMM.d(e.g. 1000024.3, 1000025.1)pkg/sql/catalog/systemschema_testwere changed, run:./dev test pkg/sql/catalog/systemschema_test -f=TestValidateSystemSchemaAfterBootStrap --rewrite./dev test pkg/sql/catalog/bootstrap --rewrite -f TestInitialValuesToStringand follow instructions from test output -- i.e. updatesystem hash=andtenant hash=insql/catalog/bootstrap/testdata-- until test passesRelease note: None
Epic: None
Release justification: release-process-only change.