Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Licensing FAQs for v24.3 release #19002

Merged
merged 15 commits into from
Nov 14, 2024

Conversation

rmloveland
Copy link
Contributor

@rmloveland rmloveland commented Oct 10, 2024

Addresses:

Summary of changes:

  • Update 'Licensing FAQs' with the following:

    • Information about the new licensing tiers

    • Instructions for self-serve Enterprise Trial and Enterprise Free
      licenses in Cloud Console

    • Updated information about how to monitor for license expiry in DB
      Console (with a link to updated UI docs that include the exact
      messages)

    • A description of what throttling is and how it works

    • A note that single-node developer clusters do not require a license
      key

  • Update 'DB Console Overview > License expiration message' with the
    specific messages that may be emitted by Console depending on the
    status of the cluster's license

Rendered previews:

NB. These changes only apply to v24.3 docs right now, but once reviewed and approved, these changes will also be backported to v23.1+ docs and sit on a branch awaiting the relevant point releases of those versions in November.

@rmloveland rmloveland marked this pull request as draft October 10, 2024 15:59
Copy link

github-actions bot commented Oct 10, 2024

Files changed:

Copy link

netlify bot commented Oct 10, 2024

Deploy Preview for cockroachdb-interactivetutorials-docs canceled.

Name Link
🔨 Latest commit baabc60
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-interactivetutorials-docs/deploys/673666b5251a1e000862501f

Copy link

netlify bot commented Oct 10, 2024

Deploy Preview for cockroachdb-api-docs canceled.

Name Link
🔨 Latest commit baabc60
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-api-docs/deploys/673666b537140b00085f2abc

Copy link

netlify bot commented Oct 10, 2024

Deploy Preview for cockroachdb-docs failed. Why did it fail? →

Name Link
🔨 Latest commit 01e6c09
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-docs/deploys/6707f9dd2b59a200080844f7

Copy link

netlify bot commented Oct 10, 2024

Netlify Preview

Name Link
🔨 Latest commit baabc60
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-docs/deploys/673666b5a63a530008ea1c9d
😎 Deploy Preview https://deploy-preview-19002--cockroachdb-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rmloveland rmloveland force-pushed the 20241010-DOC-11203-update-licensing-faq branch from df3f405 to 836c8ca Compare October 15, 2024 16:13
@rmloveland rmloveland force-pushed the 20241010-DOC-11203-update-licensing-faq branch 5 times, most recently from 846a969 to e66bbd2 Compare October 21, 2024 15:52
@rmloveland rmloveland marked this pull request as ready for review October 21, 2024 15:53
@rmloveland rmloveland force-pushed the 20241010-DOC-11203-update-licensing-faq branch from e66bbd2 to 681e7dc Compare October 21, 2024 15:55
@rmloveland
Copy link
Contributor Author

@jaiayu could use your feedback on basically this whole PR. This is a first step; next I'll plan to add an 'Enterprise Licensing Workflows' page which contains the self-serve license info as well for easier finding / sharing, probably with more info too. Also a 'Telemetry' page. But this at least gets the basic instructions and info written down (I hope) - but please let me know if you see something wrong or missing

@spilchen please look at the stuff about throttling and developer single-node clusters and let me know if anything is wrong or missing

@dhartunian please look at the changes to the 'DB Console Overview > License expiration message', I've updated it to match the telemetry notices/warnings shown in DB Console based on some screenshots you shared a while back. I'm adding it here so folks can search for the exact strings in docs. Please let me know if the text of the messages has changed. Also i'm open to any other feedback re: stuff that is wrong or missing

Thank you!

Copy link

@spilchen spilchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I just had a couple of questions and clarificatons.

src/current/_includes/common/set-enterprise-license.md Outdated Show resolved Hide resolved
src/current/_includes/common/licensing-faqs.md Outdated Show resolved Hide resolved
src/current/_includes/common/licensing-faqs.md Outdated Show resolved Hide resolved
src/current/_includes/common/licensing-faqs.md Outdated Show resolved Hide resolved
Copy link
Contributor

@dhartunian dhartunian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DB Console text LGTM.

We will enforce the sending of telemetry within the DB if the customer has a Free/Trial license (they can't disable via the cluster setting), so if they get a telemetry send error, it will be due to a firewall configuration or a network issue. Is it worth mentioning that somewhere?

@rmloveland
Copy link
Contributor Author

@dhartunian :

DB Console text LGTM.

yayyy thanks

We will enforce the sending of telemetry within the DB if the customer has a Free/Trial license (they can't disable via the cluster setting), so if they get a telemetry send error, it will be due to a firewall configuration or a network issue. Is it worth mentioning that somewhere?

I added a line to reference this in the 'Types of Licenses' section, PTAL

Clusters with Enterprise Free or Enterprise Trial licenses cannot disable telemetry; if such a cluster signals a telemetry sending error, it will be due to firewall configuration or a network issue.

@@ -0,0 +1,9 @@
Depending on the status of your cluster's [license]({% link {{ page.version.version }}/licensing-faqs.md %}), the following messages may be displayed in the DB Console:

- If the license will expire soon, the message is: _This cluster will require a license key by ${DATE} or the cluster will be throttled._
Copy link

@jaiayu jaiayu Oct 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this error is only displayed if there is no license key in the first place (not is expiring soon)

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't actually display a message when the cluster is expiring soon. We only display the banner alerts when the license has actually expired and the cluster is in a grace period before clusters are throttled:

"Your license key expired on . The cluster will be throttled on unless a new license key is added. Learn more"

Copy link
Contributor Author

@rmloveland rmloveland Oct 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this error is only displayed if there is no license key in the first place (not is expiring soon)
We don't actually display a message when the cluster is expiring soon.

Ah ok, i took these from some UI screenshots that were shared a while back. Makes sense that they got out of date, thanks for the updated info

We only display the banner alerts when the license has actually expired and the cluster is in a grace period before clusters are throttled:

"Your license key expired on . The cluster will be throttled on unless a new license key is added. Learn more"

Ok, updated to the following:

  • If your cluster has an invalid license key and the cluster is still in the grace period, the message is: Your license key expired on ${DATE1}. The cluster will be throttled on ${DATE2} unless a new license key is added.

Copy link
Contributor Author

@rmloveland rmloveland Nov 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jaiayu OK with these changes? OK to resolve this convo?


- If the license will expire soon, the message is: _This cluster will require a license key by ${DATE} or the cluster will be throttled._
- If the license is no longer valid, the message is: _Your license key expired on ${DATE} and the cluster was throttled. Please add a license key to continue using this cluster._
- If the cluster is required to send telemetry but has not been sending it, the message is: _Telemetry has not been received from some nodes in this cluster since ${DATE}. These nodes will be throttled on ${DATE} unless telemetry is received._
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a separate message displayed after the throttling occurs due to telemetry requirements:
"Telemetry has not been received from some nodes in this cluster since . These nodes were throttled on July . Learn more"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, added another bullet and ordered them together as follows:

  • If the cluster is required to send telemetry but has not been sending it, and is not yet being throttled, the message is: Telemetry has not been received from some nodes in this cluster since ${DATE}. These nodes will be throttled on ${DATE} unless telemetry is received.
  • If the cluster is required to send telemetry but has not been sending it, and is currently being throttled, the message is: Telemetry has not been received from some nodes in this cluster since ${DATE1}. These nodes were throttled on ${DATE2}.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jaiayu ok with the updates i made here to resolve this?

@rmloveland
Copy link
Contributor Author

@taroface FYI this has completed legal review and is 100% ready for your review

i know i have 1000000 things in your queue, but this is the number 1 thing i'd say

Copy link
Contributor

@taroface taroface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Various mostly optional nits, a couple instances of broken formatting.

src/current/_data/redirects.yml Show resolved Hide resolved
src/current/_includes/common/licensing-faqs.md Outdated Show resolved Hide resolved
src/current/_includes/common/licensing-faqs.md Outdated Show resolved Hide resolved
src/current/_includes/common/licensing-faqs.md Outdated Show resolved Hide resolved
src/current/_includes/common/set-enterprise-license.md Outdated Show resolved Hide resolved
Addresses:

- DOC-11203
- DOC-11048
- DOC-11049

Summary of changes:

- Update 'Licensing FAQs' with the following:

  - Information about the new licensing tiers

  - Instructions for self-serve Enterprise Trial and Enterprise Free
    licenses in Cloud Console

  - Updated information about how to monitor for license expiry in DB
    Console (with a link to updated UI docs that include the exact
    messages)

  - A description of what throttling is and how it works

  - A note that single-node developer clusters do not require a license
    key

- Update 'DB Console Overview > License expiration message' with the
  specific messages that may be emitted by Console depending on the
  status of the cluster's license
@rmloveland rmloveland force-pushed the 20241010-DOC-11203-update-licensing-faq branch from 28ff22e to 10bcfca Compare November 14, 2024 20:51
@rmloveland rmloveland enabled auto-merge (squash) November 14, 2024 21:09
@rmloveland rmloveland merged commit 7d297eb into main Nov 14, 2024
7 checks passed
@rmloveland rmloveland deleted the 20241010-DOC-11203-update-licensing-faq branch November 14, 2024 21:16
rmloveland added a commit that referenced this pull request Nov 14, 2024
Addresses DOC-11674

Backport changes from #19002
rmloveland added a commit that referenced this pull request Nov 15, 2024
Addresses DOC-11674

Backport changes from #19002
rmloveland added a commit that referenced this pull request Nov 15, 2024
Addresses DOC-11674

Backport changes from #19002
rmloveland added a commit that referenced this pull request Nov 15, 2024
* Backport changes from #19002

Addresses DOC-11674
rmloveland added a commit that referenced this pull request Nov 18, 2024
* Backport changes from #19008 (#19106)

Addresses DOC-11674

Summary of changes:

- Backport changes from #19008 to v23.1, v23.2, v24.1,
  and v24.2

* Backport changes from #19072 (#19109)

* Backport changes from #19072

Addresses DOC-11674

Summary of changes:

- Backport #19072 to v23.1, v23.2, v24.1, v24.2

* Backport changes from #19031 (#19108)

Addresses DOC-11674

Summary of changes:

- Backport #19031 to v23.1, v23.2, v24.1, v24.2

* Backport changes from #19001 (#19103)

Addresses DOC-10665, DOC-11674

Summary of changes:

- Backport changes from #19001; a few manual edits were
  required due to a few patches that didn't merge automagically

* Backport changes from #19126 (#19133)

Addresses DOC-11674, DOC-11692

* Merge origin/main into 20241029-DOC-10624-backports (#19140)

* Merge origin/main back into core relicensing backport branch (#19142)

* Backport changes from #19002 (#19138)

* Backport changes from #19002

Addresses DOC-11674

* Backport telemetry docs from #19131 (#19145)

Addresses DOC-11051

* Backport upgrade license info from #19125 (#19146)

Addresses DOC-11693

* Fix broken link on upgrade page include

---------

Co-authored-by: Rich Loveland <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants