crl-release-23.1: bump commit pipeline constants #2770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Increase CapAllocatedBlocks to 512, allowing allocating up to 512 * 32 KiB = 16 MiB of blocks for WAL writes. In heavy-write workloads with large records, we've observed excessive queueing in the WAL writer waiting for free blocks. Queueing here is undesirable, as it blocks all commit pipeline writes. In future work, we could consider adapting this capacity to scale as the memtable size scales.
Increase record.SyncConcurrency to 4096 to allow additional concurrency within the commit pipeline. In workloads with heavy writes and high concurrency, we've observed semaphore queueing artifically increasing tail latencies.
|
This change is |
sumeerbhola
approved these changes
Jul 25, 2023
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @jbowens)
|
TFTR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes a 23.1 backport of #2764. Additionally, it contains a safer alternative to #2762, bumping the maximum allocated LogWriter blocks to 512. These are being backported as a part of a commitment to a customer.