Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crl-release-23.1: bump commit pipeline constants #2770

Merged
merged 2 commits into from
Jul 25, 2023
Merged

crl-release-23.1: bump commit pipeline constants #2770

merged 2 commits into from
Jul 25, 2023

Commits on Jul 24, 2023

  1. record: increase CapAllocatedBlocks 

    Increase CapAllocatedBlocks to 512, allowing allocating up to 512 * 32 KiB = 16
MiB of blocks for WAL writes. In heavy-write workloads with large records,
we've observed excessive queueing in the WAL writer waiting for free blocks.
Queueing here is undesirable, as it blocks all commit pipeline writes. In
future work, we could consider adapting this capacity to scale as the memtable
size scales.
    @jbowens
    jbowens committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    09cc796 View commit details
    Browse the repository at this point in the history

  2. record: increase record.SyncConcurrency 

    Increase record.SyncConcurrency to 4096 to allow additional concurrency within
the commit pipeline. In workloads with heavy writes and high concurrency, we've
observed semaphore queueing artifically increasing tail latencies.
    @jbowens
    jbowens committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    880e7c4 View commit details
    Browse the repository at this point in the history