v3.8.0-4 round: fix unlink prefab bug in inspector #15518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Interface Check ReportThis pull request does not change any public interfaces ! |
dogeFu
reviewed
Jun 25, 2023
| } | ||
| } | ||
| } | ||
| const undoID = await beginRecording(recordings); |
There was a problem hiding this comment.
unlink-prefab不需要在业务层记录undo，场景中unlink时已经记录好了https://github.com/cocos/editor-extensions/pull/595
dogeFu
reviewed
Jun 25, 2023
| } | ||
| } | ||
| } | ||
| const undoID = await beginRecording(recordings); |
There was a problem hiding this comment.
这里如果recordings没有uuid最好不要beginRecording
dogeFu
approved these changes
Jun 25, 2023
VisualSJ
approved these changes
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: #
Changelog
Continuous Integration
This pull request:
Compatibility Check
This pull request: