Add Epilogue Pipeline for PVC using EVT #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mehdi-goli
reviewed
May 31, 2024
mehdi-goli
reviewed
May 31, 2024
mehdi-goli
reviewed
May 31, 2024
mehdi-goli
reviewed
May 31, 2024
mehdi-goli
reviewed
May 31, 2024
mehdi-goli
reviewed
May 31, 2024
aacostadiaz
reviewed
Jun 3, 2024
aacostadiaz
reviewed
Jun 3, 2024
muhammad-tanvir-1211
force-pushed
the
intel-epilogue
branch
from
23ddf3c
to
3755c7c
Compare
* Next need to integrate EVT
* Alpha scaling working, need to fix copy atom for C
* Need to remove register spill * Need to reduce error margin
aacostadiaz
force-pushed
the
intel-epilogue
branch
from
3755c7c
to
8d1f87b
Compare
rolandschulz
approved these changes
Jul 1, 2024
| class CopyOpR2S_ | ||
| > | ||
| class CollectiveEpilogue< | ||
| IntelPVCEpilogue, |
There was a problem hiding this comment.
Is anything PVC specific? Might IntelXeEpilogue might be better.
There was a problem hiding this comment.
Actually, we should check that. We are using PVC in some places and Xe in others, but I'm not entirely sure we are naming things correctly. I'll address this in a separate PR.
Jiaxingla
pushed a commit
to Jiaxingla/cutlass-fork
that referenced
this pull request
Jul 16, 2024
This PR introduces the Epilogue implementation for PVC using the Epilogue Visitor Tree available for SM90 (and onwards) GPUs for NVIDIA. We only support fusion::LinearCombination operation for PVC i.e. D = alpha * A * B + beta * C through this PR, but it can be extended further to add other fusion operations by partial specialization of the FusionCallBacks struct available in the include/cutlass/epilogue/fusion/intel_pvc_callbacks.hpp file. --------- Co-authored-by: Alejandro Acosta <[email protected]>
aacostadiaz
added a commit
that referenced
this pull request
Jul 16, 2024
This PR introduces the Epilogue implementation for PVC using the Epilogue Visitor Tree available for SM90 (and onwards) GPUs for NVIDIA. We only support fusion::LinearCombination operation for PVC i.e. D = alpha * A * B + beta * C through this PR, but it can be extended further to add other fusion operations by partial specialization of the FusionCallBacks struct available in the include/cutlass/epilogue/fusion/intel_pvc_callbacks.hpp file. --------- Co-authored-by: Alejandro Acosta <[email protected]>
aacostadiaz
added a commit
to aacostadiaz/cutlass-fork
that referenced
this pull request
Aug 6, 2024
This PR introduces the Epilogue implementation for PVC using the Epilogue Visitor Tree available for SM90 (and onwards) GPUs for NVIDIA. We only support fusion::LinearCombination operation for PVC i.e. D = alpha * A * B + beta * C through this PR, but it can be extended further to add other fusion operations by partial specialization of the FusionCallBacks struct available in the include/cutlass/epilogue/fusion/intel_pvc_callbacks.hpp file. --------- Co-authored-by: Alejandro Acosta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the Epilogue implementation for PVC using the Epilogue Visitor Tree available for SM90 (and onwards) GPUs for NVIDIA. We only support
fusion::LinearCombinationoperation for PVC i.e.D = alpha * A * B + beta * Cthrough this PR, but it can be extended further to add otherfusionoperations by partial specialization of theFusionCallBacksstruct available in theinclude/cutlass/epilogue/fusion/intel_pvc_callbacks.hppfile.