Fix bug in omatcopy_batch and omatadd_batch operators #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current non-transpose implementation has a bug in the type for alpha scalar. This commit fix it.
Update test to properly check floating points values for alpha and beta.
pgorlani
approved these changes
Nov 1, 2023
muhammad-tanvir-1211
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a bug in the current
non-transposeimplementation ofomatcopy_batchandomatadd_batchoperators.It sets
alphaandbetavalues asindex_ttype instead ofvalue_ttype. In case ofvalue_tbeing a floating point type, it caused an implicit cast from floating point to integer type that lead to wrong computation.