Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug in omatcopy_batch and omatadd_batch operators #476

Merged
merged 2 commits into from
Nov 6, 2023
Merged

Fix bug in omatcopy_batch and omatadd_batch operators #476

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a601e30
Fix bugs in matcopy_batch operators
s-Nick Oct 31, 2023
b165505
Update test for copy operators
s-Nick Oct 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/operations/extension/matcopy_batch.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ Matcopy_batch<is_add, TileSize, TilePerWG, lhs_t, rhs_t,
orig_rhs = orig_rhs + wg_row + wg_col * rhs_1_ld_ + item_id;

value_t reg_rhs[TileSize];
const index_t alpha = alpha_;
const value_t alpha = alpha_;

const bool is_internal_block =
(m - wg_row >= TileSize) && (n - wg_col >= TileSize);
Expand Down Expand Up @@ -151,8 +151,8 @@ Matcopy_batch<is_add, TileSize, TilePerWG, lhs_t, rhs_t,

value_t reg_rhs[TileSize];
value_t reg_rhs_2[TileSize];
const index_t alpha = alpha_;
const index_t beta = beta_;
const value_t alpha = alpha_;
const value_t beta = beta_;

const bool is_internal_block =
(m - wg_row >= TileSize) && (n - wg_col >= TileSize);
Expand Down
4 changes: 2 additions & 2 deletions test/unittest/extension/omatadd_batched_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,8 +160,8 @@ const auto combi =
::testing::Values<char>('n', 't'), // trans_b
::testing::Values<index_t>(64, 129, 255), // m
::testing::Values<index_t>(64, 129, 255), // n
::testing::Values<scalar_t>(2), // alpha
::testing::Values<scalar_t>(2), // beta
::testing::Values<scalar_t>(2.5), // alpha
::testing::Values<scalar_t>(3.5), // beta
::testing::Values<index_t>(1, 2), // lda_mul
::testing::Values<index_t>(1, 2), // ldb_mul
::testing::Values<index_t>(1, 2, 3), // ldc_mul
Expand Down
2 changes: 1 addition & 1 deletion test/unittest/extension/omatcopy_batched_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ const auto combi =
::testing::Values<char>('n', 't'), // trans
::testing::Values<index_t>(64, 129, 255), // m
::testing::Values<index_t>(64, 129, 255), // n
::testing::Values<scalar_t>(0, 2), // alpha
::testing::Values<scalar_t>(0, 2.5), // alpha
::testing::Values<index_t>(1, 2, 3), // ld_in_m
::testing::Values<index_t>(1, 2, 3), // ld_out_m
::testing::Values<index_t>(1, 3), // stride_in_m
Expand Down