Remove the CapacityThresholds from ToolchainConfig

[metlos]

This updates the code and tests to not use CapacityThresholds from ToolchainConfig for anything because this field has been removed from the api.

See https://issues.redhat.com/browse/KUBESAW-36.

Associated PRs:
- toolchain-common: codeready-toolchain/toolchain-common#379
- toolchain-e2e: codeready-toolchain/toolchain-e2e#935
- api: codeready-toolchain/api#411

[metlos]

/retest

[MatousJobanek]

looks good, but include the regenerated CRD please

[rsoaresd]

Latest run failed with:

        	Error:      	Received unexpected error:
        	            	timed out waiting for the condition
        	Test:       	TestE2EFlow/verify_Space_is_not_deleted_if_namespace_is_not_deleted
push_pin
        	Messages:   	The proper cleanup of the UserSignup 'laracroft' and related resources wasn't finished within the given timeout
        	            	the UserSignup 'laracroft' has been cleaned properly 
        	            	the MasterUserRecord 'laracroft' has been cleaned properly 
        	            	the Space 'laracroft' is still present in the cluster

I saw that also happened in the past 13 days in registration-service job. Very likely is a flaky test. I will investigate it.

[metlos]

/retest

[metlos]

/retest

[rsoaresd]

Hello, @metlos!

The last two runs are hitting:

level=error msg=failed to fetch Master Machines: failed to load asset "Install Config": failed to create install config: [controlPlane.platform.aws: Internal error: error listing instance types: fetching instance types: UnauthorizedOperation: You are not authorized to perform this operation. User: arn:aws:iam::767398085593:user/sandboxOpenShiftCI is not authorized to perform: ec2:DescribeInstanceTypes with an explicit deny in a service control policy
level=error msg=	status code: 403, request id: a6397df6-1005-4af8-8363-71e8444946da, compute[0].platform.aws: Internal error: error listing instance types: fetching instance types: UnauthorizedOperation: You are not authorized to perform this operation. User: arn:aws:iam::7673980[85](https://prow.ci.openshift.org/spyglass/lens/buildlog/iframe?req=%7B%22artifacts%22%3A%5B%22build-log.txt%22%5D%2C%22index%22%3A1%2C%22src%22%3A%22gs%2Ftest-platform-results%2Fpr-logs%2Fpull%2Fcodeready-toolchain_host-operator%2F1000%2Fpull-ci-codeready-toolchain-host-operator-master-e2e%2F1777609530872434688%22%7D&topURL=https%3A//prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/codeready-toolchain_host-operator/1000/pull-ci-codeready-toolchain-host-operator-master-e2e/1777609530872434688&lensIndex=1#build-log.txt:85)593:user/sandboxOpenShiftCI is not authorized to perform: ec2:DescribeInstanceTypes with an explicit deny in a service control policy
level=error msg=	status code: 403, request id: d410e482-1dfe-448f-8b6a-64cc34f854ee]
Create manifests exit code: 3

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexeykazakov, fbm3307, MatousJobanek, metlos, rajivnathan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [MatousJobanek,alexeykazakov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[metlos]

/retest

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
12.1% Duplication on New Code

See analysis details on SonarCloud

[codecov]

Codecov Report

Merging #1000 (78aac17) into master (248d35e) will decrease coverage by 0.03%.
The diff coverage is n/a.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1000      +/-   ##
==========================================
- Coverage   84.62%   84.59%   -0.03%     
==========================================
  Files          55       55              
  Lines        4852     4844       -8     
==========================================
- Hits         4106     4098       -8     
  Misses        573      573              
  Partials      173      173              

Files	Coverage Δ
controllers/toolchainconfig/configuration.go	91.66% <ø> (-0.44%)	⬇️