move float metrics compare wrapper to common #1073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ranakan19
requested review from
MatousJobanek,
xcoulon,
alexeykazakov,
rajivnathan,
sbryzak and
mfrancisc
as code owners
xcoulon
approved these changes
Aug 14, 2024
alexeykazakov
approved these changes
Aug 14, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexeykazakov, MatousJobanek, ranakan19, xcoulon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1073 +/- ##
==========================================
+ Coverage 85.06% 85.08% +0.01%
==========================================
Files 55 55
Lines 5034 5034
==========================================
+ Hits 4282 4283 +1
+ Misses 581 580 -1
Partials 171 171 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wrt to conversation - #1072 (comment)
Moving float metrics comparision wrapper to toolchain-common to avoid cyclic import dependency when trying to replace
assert.EqualwithAssertMetricsCounterEquals.related PR: codeready-toolchain/toolchain-common#423