Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move float metrics compare wrapper to common #1073

Merged
merged 2 commits into from
Aug 15, 2024
Merged

move float metrics compare wrapper to common #1073

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0cf8f71
move float metrics compare wrapper to common
ranakan19 Aug 14, 2024
5026745
update toolchain-common version
ranakan19 Aug 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions controllers/deactivation/deactivation_controller_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ import (
toolchainv1alpha1 "github.com/codeready-toolchain/api/api/v1alpha1"
"github.com/codeready-toolchain/host-operator/pkg/apis"
"github.com/codeready-toolchain/host-operator/pkg/metrics"
. "github.com/codeready-toolchain/host-operator/test"
testusertier "github.com/codeready-toolchain/host-operator/test/usertier"
"github.com/codeready-toolchain/toolchain-common/pkg/condition"
commonconfig "github.com/codeready-toolchain/toolchain-common/pkg/configuration"
Expand All @@ -23,6 +22,7 @@ import (
commontest "github.com/codeready-toolchain/toolchain-common/pkg/test"
testconfig "github.com/codeready-toolchain/toolchain-common/pkg/test/config"
murtest "github.com/codeready-toolchain/toolchain-common/pkg/test/masteruserrecord"
metricstest "github.com/codeready-toolchain/toolchain-common/pkg/test/metrics"

"github.com/stretchr/testify/require"
corev1 "k8s.io/api/core/v1"
Expand Down Expand Up @@ -518,7 +518,7 @@ func TestReconcile(t *testing.T) {
require.False(t, res.Requeue, "requeue should not be set")
require.Equal(t, time.Duration(0), res.RequeueAfter, "requeue should not be set")
assertThatUserSignupStateIsDeactivated(t, cl, username, true)
AssertMetricsCounterEquals(t, 1, metrics.UserSignupAutoDeactivatedTotal)
metricstest.AssertMetricsCounterEquals(t, 1, metrics.UserSignupAutoDeactivatedTotal)
})
})

Expand Down
Loading
Loading