Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add conflicting claims section on accept claims page #260

Closed
thenamankumar opened this issue May 17, 2020 · 5 comments · Fixed by #357 · May be fixed by #279
Closed

Add conflicting claims section on accept claims page #260

thenamankumar opened this issue May 17, 2020 · 5 comments · Fixed by #357 · May be fixed by #279
Labels
BOSS BOUNTY: 200 BOUNTY: 500

Comments

@thenamankumar
Copy link
Contributor

thenamankumar commented May 17, 2020 •
edited
Loading

Based on the issue and pull request url, find the list of conflicting claims and display them on the accept claims page.

Solutions with better layout, and covering all the edge cases will be preferred.

Things to take care of:

  1. If the target claim is for a pull request (i.e the pull request url point to a pr on github and not an issue), then only find conflicting claims which are also for a PR only. Some claims are added for suggesting features/issues, in that case the the pull request url point to an issue on github.
  2. There can be terminating '/' in some urls and not others. Can be similar cases for 'http' and 'https'. Use the like sql operator to make db queries where ever required to cover such cases.

This issue has 700 bounty points.

Screenshot 2020-05-17 at 8 36 55 PM
@thenamankumar thenamankumar mentioned this issue May 17, 2020
Open
@YashKumarVerma
Copy link
Contributor

YashKumarVerma commented May 17, 2020 •
edited
Loading

I would like to work on it once #241 is cleared out, as it stops from setting up a local dev environment

sending PR.

@prabalsingh24 prabalsingh24 mentioned this issue May 18, 2020
Closed
YashKumarVerma added a commit to YashKumarVerma/boss that referenced this issue May 18, 2020
@YashKumarVerma
New Feature : conflicting claims : Fixes coding-blocks#260
6ad5b9f
@YashKumarVerma YashKumarVerma mentioned this issue May 18, 2020
Open
4 tasks
@prathambatra
Copy link
Contributor

@hereisnaman can I work on this?

@thenamankumar
Copy link
Contributor Author

@hereisnaman can I work on this?

why not

@YashKumarVerma
Copy link
Contributor

@hereisnaman can I work on this?

There's an active pr going for this : #279

@thenamankumar
Copy link
Contributor Author

@hereisnaman can I work on this?

There's an active pr going for this : #279

Leave it for me to decide which PR to merge.

The PRs are merged based on code quality and best solutions. Until there is already a good enough solution, anyone can work on it.

YashKumarVerma added a commit to YashKumarVerma/boss that referenced this issue May 18, 2020
@YashKumarVerma
feat: conflicting claims : Fixes coding-blocks#260
14c7ec0
This was referenced May 19, 2020
Closed
Closed
@prathambatra prathambatra mentioned this issue May 27, 2020
Merged
YashKumarVerma added a commit to YashKumarVerma/boss that referenced this issue May 30, 2020
@YashKumarVerma
Fixes coding-blocks#260, conflicting analysis
e626606
@YashKumarVerma YashKumarVerma mentioned this issue May 30, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
BOSS BOUNTY: 200 BOUNTY: 500
Projects
None yet
Milestone
No milestone
3 participants
@YashKumarVerma @thenamankumar @prathambatra