Fix buf pool #98
Merged
Fix buf pool #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Making the pool state as anatomic variable is not safe enough to protect the buffer pool. When returning a buffer, the buffer state is updated atomically. Another thread may waiting on this event and immediately allocate this buffer before the actual pointer is written back to the pool. As a result, the waiting thread may write on a stale buffer and lead to silent data corruption later on. The solution is reverting back to the mutex lock which guarantee both the pool and the state are updated as a bundle.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making the pool state as anatomic variable is not safe enough to protect the buffer pool. When returning a buffer, the buffer state is updated atomically. Another thread may waiting on this event and immediately allocate this buffer before the actual pointer is written back to the pool. As a result, the waiting thread may write on a stale buffer and lead to silent data corruption later on.
The solution is reverting back to the mutex lock which guarantee both the pool and the state are updated as a bundle.