Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v4.0.0 #201

Merged
merged 148 commits into from
Jul 17, 2024
Merged

v4.0.0 #201

merged 148 commits into from
Jul 17, 2024

Conversation

RalfG
Copy link
Member

@RalfG RalfG commented Jun 25, 2023 •
edited
Loading

Fully refactored and drastically more user-friendly version of MS²PIP:

  • More modular Python API
  • One consolidated command-line interface with subcommands
  • Support for all file formats readable by psm_utils
  • Support for MGF, mzML, and Bruker raw spectrum files
  • Support for ProForma 2.0 peptide notation (no modification configuration required anymore)
  • Support for multiple peptides/PSMs per spectrum
  • Detailed documentation on ms2pip.readthedocs.io
  • ...

RalfG and others added 30 commits February 2, 2023 22:33
@RalfG
Import exceptions module completely
b603fc0
@RalfG
Refactor process_peptides and process_spectra to avoid code duplicati…
bc471fe 
…on and to allow multiple PSMs per peptide.
@RalfG
Remove obsolete tests for SinglePrediction
ea0936c
@RalfG
Remove old feature_names code (should still be reimplemented)
ba7d1ee
@RalfG
Merge branch 'releases' of https://github.com/compomics/ms2pip_c into…
075e172 
… more-refactoring
@ArthurDeclercq
psm_id in peprec/pred_emp
2ff4e5c
@RalfG
Restructured Python API and CLI (WIP)
dcc5279
@RalfG
Merge branch 'more-refactoring' of https://github.com/compomics/ms2pip_c
7dd257b 
 into more-refactoring-rg
@RalfG
Reorder psm_id
f56c967
@RalfG
Move package metadata to pyproject.tom
afac375
@ArthurDeclercq
change return_results to MSPIP obj
7dfd636
@RalfG
Restructure package; remove obsolete and unused code
5ace6c8
@RalfG
Merge branch 'more-refactoring' of https://github.com/compomics/ms2pip_c
de89bc5 
 into more-refactoring
@RalfG
More restructuring (WIP)
5945ab8
@RalfG
Implement ProcessingResult
19ed993
@RalfG
Update pyproject, setup.py, manifest
876b5b1
@RalfG
Add psm_id before filtering input; do not use yield in batch_processing
dc200fe
@RalfG
Implement psm_list throughout MS²PIP, removing peprec dataframe usage
2f2b82e
@ArthurDeclercq
logging for modification handling
0c2c1e4
@ArthurDeclercq
Merge branch 'more-refactoring' of https://github.com/compomics/ms2pip …
ff17054 
…into more-refactoring
@ArthurDeclercq
put warning for modificaiton on invalid aa
9150dc5
@ArthurDeclercq
import change
559a3d4
@RalfG
Further refactoring for 4.0:
6642566 
- Reimplement encoder to fully support ProForma without PEPREC intermediate.
- Reimplement multiprocessing chunking approach to improve handling of very large PSM files.
- Add psm_index to output.
- Move batch_processing back into core.
- Move encoder out of _utils
@RalfG
Merge branch 'more-refactoring' of https://github.com/compomics/ms2pip_c
b2fe5a6 
 into more-refactoring
@ArthurDeclercq
bug fix invalid modification
d6e18b2
@RalfG
Fix invalid modification bug in encoder
70a161d
@RalfG
Merge branch 'more-refactoring' of https://github.com/compomics/ms2pip_c
36ba316 
 into more-refactoring
@RalfG
Remove typing of optional spectrum_utils import
f824356
@RalfG
Temporarily disable tests (outdated)
36724ae
@RalfG
Remove match_spectra functionality
8e044d8 
(Could be re-added and implemented if ever needed)
RalfG added 16 commits May 8, 2024 15:19
@RalfG
Fix linting errors
8a91a57
@RalfG
Merge pull request #220 from compomics/spectrum-output
bd66087 
Reimplement spectrum_output module for v4
@RalfG
Merge branch 'v4.0.0' of https://github.com/compomics/ms2pip_c into r…
a959f75 
…eimplement-predict-library
@RalfG
Implement spectrum-output for predict-library
a879808
@RalfG
Avoid memory issues by converting to Peptidoforms lazily
66c5c2a
@RalfG
Remove obsolete tests; fix search space test imports
345ccd8
@RalfG
CI: Reinstate tests
b09f4e9
@RalfG
Remove unused import; clean up test imports
92088fa
@RalfG
Fix test workflow
7ac939c
@RalfG
Fix search_space_test
5d1f11a
@RalfG
Merge pull request #219 from compomics/reimplement-predict-library
e595c9d 
Reimplement predict library
@RalfG
Update docs
ab81ad4
@RalfG
Doc updates; version bump
a335bf2
@RalfG
predict-library: Allow fasta file to be missing from config file if p…
1ad181b 
…rovided in CLI
@RalfG
Fix build artifact upload
2275a97
@RalfG
Revert fasta assignment
fd34319
@RalfG RalfG merged commit 9202563 into releases Jul 17, 2024
4 checks passed
@RalfG RalfG deleted the v4.0.0 branch July 17, 2024 15:27
@RalfG RalfG mentioned this pull request Sep 16, 2024
Closed
@RalfG RalfG added this to the v4.0.0 milestone Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v4.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@RalfG @ArthurDeclercq @jaspervdh @Cajac102 @rodvrees