Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version to Gazebo 11.3.0 #37

Merged
merged 8 commits into from
Nov 28, 2020
Merged

Bump version to Gazebo 11.3.0 #37

merged 8 commits into from
Nov 28, 2020

Conversation

traversaro
Copy link
Contributor

@traversaro traversaro commented Nov 26, 2020

Version based on #36 with some fixes.

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@wolfv
Copy link
Member

wolfv commented Nov 28, 2020

this is ready @traversaro ? looks excellent to me :)

@traversaro
Copy link
Contributor Author

traversaro commented Nov 28, 2020

Yes! I tried to check if we could port some other of @Tobias-Fischer *nix patches upstream, but most of them are actually due to a really peculiar cmake/conda bug. I will eventually report ot to cmake-feedstock as at the moment I don't have any idea how to approach it, and that fortunately does not affect most of CMake projects that instead use the so-called "Modern CMake".

@traversaro
Copy link
Contributor Author

Yes! I tried to check if we could port some other of @Tobias-Fischer *nix patches upstream, but most of them are actually due to a really peculiar cmake/conda bug. I will eventually report ot to cmake-feedstock as at the moment I don't have any idea how to approach it, and that fortunately does not affect most of CMake projects that instead use the so-called "Modern CMake".

Related bug: conda-forge/cmake-feedstock#129 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants