GHA: Fix indentation error and skip image.rs tests for s390x #586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BbolroC
force-pushed
the
fix-indentation-error
branch
from
7965106
to
b69baf0
Compare
The commit fixes the wrongly indented configuration in confidential-containers#585 and place the pre action step after the code check-out. Signed-off-by: Hyounggyu Choi <[email protected]>
BbolroC
force-pushed
the
fix-indentation-error
branch
from
b69baf0
to
f6a319f
Compare
BbolroC
requested review from
jiangliu,
arronwy,
lumjjb,
jialez0 and
Xynnn007
as code owners
BbolroC
changed the title
BbolroC
force-pushed
the
fix-indentation-error
branch
2 times, most recently
from
8c1e93f
to
a7df614
Compare
There is an issue on pulling an image `mcr.microsoft.com/hello-world` on s390x. It looks a load balancer for the microsoft registry is unstable so that the runner was able to pull the image with 10& success ratio (see microsoft/containerregistry#144) It is not reasonable to let the test run under the unstable environment. This commit skips the tests at image.rs for the platform. Signed-off-by: Hyounggyu Choi <[email protected]>
BbolroC
force-pushed
the
fix-indentation-error
branch
from
a7df614
to
1266b08
Compare
Xynnn007
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the wrongly indented configuration in #585 and place the pre action step after the code check-out.
There is an issue on pulling an image
mcr.microsoft.com/hello-worldon s390x.It looks a load balancer for the microsoft registry is unstable so that the runner was able to pull the image with 10& success ratio (see microsoft/containerregistry#144)
It is not reasonable to let the test run under the unstable environment.
This commit skips the tests at image.rs for the platform.
Signed-off-by: Hyounggyu Choi [email protected]