Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GHA: Fix indentation error and skip image.rs tests for s390x #586

Merged
merged 2 commits into from
Jun 14, 2024
Merged

GHA: Fix indentation error and skip image.rs tests for s390x #586

merged 2 commits into from
Jun 14, 2024

Commits on Jun 14, 2024

  1. GHA: Fix indentation error 

    The commit fixes the wrongly indented configuration in confidential-containers#585
and place the pre action step after the code check-out.

Signed-off-by: Hyounggyu Choi <[email protected]>
    @BbolroC
    BbolroC committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    f6a319f View commit details
    Browse the repository at this point in the history

  2. tests: Skip image.rs test for s390x 

    There is an issue on pulling an image `mcr.microsoft.com/hello-world` on s390x.
It looks a load balancer for the microsoft registry is unstable so that the runner
was able to pull the image with 10& success ratio (see
microsoft/containerregistry#144)
It is not reasonable to let the test run under the unstable environment.

This commit skips the tests at image.rs for the platform.

Signed-off-by: Hyounggyu Choi <[email protected]>
    @BbolroC
    BbolroC committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    1266b08 View commit details
    Browse the repository at this point in the history