Serialization #50
Closed
Serialization #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pczarn
reviewed
Mar 11, 2019
| serde_json = "1.0" | ||
|
|
||
| [dependencies] | ||
| serde = "1.0" |
There was a problem hiding this comment.
The crate is added, but why is it not listed as extern crate? Is it because of the recent changes in the 2018 Edition? If so, I'm not familiar.
There was a problem hiding this comment.
If I recall correctly (almost a year ago), serde_derive did require serde to work, but you did not actually need to call extern crate for it.
|
Please add this support behind an optional feature flag. An example of how to do this exactly: https://github.com/chronotope/chrono/blob/master/src/lib.rs#L38-L39 Except that serde_derive should be a regular dependency, not a dev dependency. |
|
OK, closing in favor of the more recent PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for serialization with serde. This is required to add serialization support to
BitSetin thebit_setcrate as mentioned here.I increased the version number so that
bit_setcan require version0.6.0since the changes toBitSetwould not compile withoutBitVecimplementing theSerializeandDeserializetraits.The test checks if the content of the array stay the same after serializing it deserializing it again.