Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for serialization of BitVec using serde #57

Merged
merged 1 commit into from
May 16, 2019

Conversation

mre
Copy link
Contributor

@mre mre commented Mar 31, 2019

This pull request adds support for serialization and deserialzation using serde.

It is based on the work of @HenningTimm in #50. I merely added the feature flag as requested by @pczarn in the comments of the previous pull request.

@HenningTimm HenningTimm mentioned this pull request Apr 1, 2019
@pczarn
Copy link
Contributor

pczarn commented May 16, 2019

We should forward the std feature to serde in two steps

  • let's pass default-features = false to serde dep, so that the default is no_std
  • forward the std feature to serde with
[features]
std = ["serde/std"]

@pczarn
Copy link
Contributor

pczarn commented May 16, 2019

Thanks for the update. OK, I will merge as-is and add my own changes if testing shows they're necessary.

What's more, we might need CI testing of no_std.

@pczarn pczarn merged commit befa723 into contain-rs:master May 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants