fix: Slice range was broken for key image setting on video #1737
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
✅ Deploy Preview for cornerstone-3d-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
sedghi
reviewed
Jan 7, 2025
| @@ -812,8 +812,10 @@ class VideoViewport extends Viewport { | |||
| let { imageURI } = options; | |||
| const { referencedImageId, sliceIndex: sliceIndex } = viewRef; | |||
| if (!super.isReferenceViewable(viewRef)) { | |||
| console.log('Video reference not viewable', viewRef); | |||
sedghi
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
When applying a key image to a video range, the playback/selection was broken and the key image only applied to a single image.
Changes & Results
Calculate the correct slice range if it isn't provided directly.
Testing
Run example videoRange, apply a key image to a range of images and ensure it displays on all the images in that range.
Checklist
PR
semantic-release format and guidelines.
Code
[] My code has been well-documented (function documentation, inline comments,
etc.)
[] I have run the
yarn build:update-apito update the API documentation, and havecommitted the changes to this PR. (Read more here https://www.cornerstonejs.org/docs/contribute/update-api)
Public Documentation Updates
additions or removals.
Tested Environment