Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Slice range was broken for key image setting on video #1737

Merged
merged 2 commits into from
Jan 7, 2025
Merged

fix: Slice range was broken for key image setting on video #1737

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
608a960
fix: Slice range was broken for key image setting on video
wayfarer3130 Jan 7, 2025
eefd9a0
Remove console logs
wayfarer3130 Jan 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/core/src/RenderingEngine/VideoViewport.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -812,8 +812,10 @@ class VideoViewport extends Viewport {
let { imageURI } = options;
const { referencedImageId, sliceIndex: sliceIndex } = viewRef;
if (!super.isReferenceViewable(viewRef)) {
console.log('Video reference not viewable', viewRef);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove?

return false;
}
console.log('Testing video reference viewable', viewRef);

const imageId = this.getCurrentImageId();
if (!imageURI) {
Expand Down Expand Up @@ -866,7 +868,7 @@ class VideoViewport extends Viewport {
public getViewReference(
viewRefSpecifier?: ViewReferenceSpecifier
): ViewReference {
let sliceIndex = viewRefSpecifier?.sliceIndex ?? this.getSliceIndex();
let sliceIndex = viewRefSpecifier?.sliceIndex;
if (!sliceIndex) {
sliceIndex = this.isPlaying
? [this.frameRange[0] - 1, this.frameRange[1] - 1]
Expand Down
Loading