Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: dropdown to inc. legacy versions and additions to homepage #14

Merged
merged 5 commits into from
Aug 14, 2023

Conversation

samricotta
Copy link
Contributor

No description provided.

},
],
},
footer: {
links: [
{
items: [
Copy link
Member

@julienrbrt julienrbrt Aug 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why deleting the logo? IMHO it should stay and be copied at static/img/logo-bw.svg to be properly resolved.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ive tried a few paths and its still not working, wanted it gone for now until i figure out the issue

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

static/img/logo-bw.svg there is still an issue too

Copy link
Member

@julienrbrt julienrbrt Aug 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yes this is because it is getting https://cosmos.github.io/img/logo-bw.svg, it will work just fine once this is in using a domain.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah ok yes fair point

@samricotta samricotta changed the title refactor: dropdown to inc. legacy versions refactor: dropdown to inc. legacy versions and additions to homepage Aug 14, 2023
@@ -107,7 +119,7 @@ const config = {
{
items: [
{
html: `<a href="https://cosmos.network"><img src="/img/logo-bw.svg" alt="Cosmos Logo"></a>`,
html: `<a href="https://cosmos.network"><img src="static/img/logo-bw.svg" alt="Cosmos Logo"></a>`,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be /static. It should stay the same. I was talking about the folder path in docusarus.

@julienrbrt julienrbrt merged commit 88f76d4 into main Aug 14, 2023
1 check passed
@julienrbrt julienrbrt deleted the update-dropdown branch August 14, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants