Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: dropdown to inc. legacy versions and additions to homepage #14

Merged
merged 5 commits into from
Aug 14, 2023
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion docusaurus.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,18 @@ const config = {
type: "docsVersionDropdown",
position: "right",
dropdownActiveClassDisabled: true,
dropdownItemsAfter: [
{
href: "https://docs.cosmos.network/v0.46/",
label: "v0.46",
target: "_self",
},
{
href: "https://docs.cosmos.network/v0.45/",
label: "v0.45",
target: "_self",
},
],
},
],
},
Expand All @@ -107,7 +119,7 @@ const config = {
{
items: [
Copy link
Member

@julienrbrt julienrbrt Aug 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why deleting the logo? IMHO it should stay and be copied at static/img/logo-bw.svg to be properly resolved.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ive tried a few paths and its still not working, wanted it gone for now until i figure out the issue

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

static/img/logo-bw.svg there is still an issue too

Copy link
Member

@julienrbrt julienrbrt Aug 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yes this is because it is getting https://cosmos.github.io/img/logo-bw.svg, it will work just fine once this is in using a domain.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah ok yes fair point

{
html: `<a href="https://cosmos.network"><img src="/img/logo-bw.svg" alt="Cosmos Logo"></a>`,
html: `<a href="https://cosmos.network"><img src="static/img/logo-bw.svg" alt="Cosmos Logo"></a>`,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be /static. It should stay the same. I was talking about the folder path in docusarus.

},
],
},
Expand Down
10 changes: 5 additions & 5 deletions src/components/HomepageFeatures/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ const FeatureList = [
},
{
title: `Join the Community`,
to: "/develop/intro/what-is-sdk",
to: "https://discord.com/invite/cosmosnetwork",
Svg: require('@site/static/img/public-service.svg').default,
description: (
<>
Expand All @@ -60,13 +60,13 @@ const FeatureList = [
),
},
{
title: `Our Vision`,
to: "/develop/intro/what-is-sdk",
title: `Discuss`,
to: "https://github.com/orgs/cosmos/discussions",
Svg: require('@site/static/img/ecosystem.svg').default,
description: (
<>
Learn about the long-term vision of the Cosmos project and how it aims to create an interoperable,
scalable, and sustainable ecosystem of blockchain applications.
Collaborative forum for the community to ask/answer questions, share information, discuss
items and give feedbacks on the teams roadmaps.
</>
),
},
Expand Down