feat(core): Add get module accounts service to core appmodule #22138
Conversation
📝 WalkthroughWalkthroughThe changes introduce a new type Changes
Sequence Diagram(s)sequenceDiagram
participant Module as Module
participant HasModuleAccounts as HasModuleAccounts Interface
participant ModuleAccount as ModuleAccount Type
Module->>HasModuleAccounts: GetModuleAccounts()
HasModuleAccounts-->>Module: Return []ModuleAccount
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
|
@sontrinh16 your pull request is missing a changelog! |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
core/appmodule/v2/module.go (1)
107-117: Consider grouping related interfaces and structsWhile the implementation is correct, consider grouping the
ModuleAccountstruct andHasModuleAccountsinterface with other related types for better code organization. This could improve readability and maintainability of the file.
📜 Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
📒 Files selected for processing (1)
- core/appmodule/v2/module.go (1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
core/appmodule/v2/module.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.
🔇 Additional comments (2)
core/appmodule/v2/module.go (2)
108-112: LGTM: ModuleAccount struct is well-definedThe
ModuleAccountstruct is correctly implemented with appropriate field types and follows Go naming conventions. The comment provides a clear description of its purpose.
114-117: LGTM: HasModuleAccounts interface is well-definedThe
HasModuleAccountsinterface is correctly implemented with a clear and descriptive method. It follows Go naming conventions and is properly documented.
| @@ -104,3 +104,14 @@ type ValidatorUpdate struct { | |||
| type HasRegisterInterfaces interface { | |||
| RegisterInterfaces(registry.InterfaceRegistrar) | |||
| } | |||
|
|
|||
| // ModuleAccount defines a module account info get from the module. | |||
| type ModuleAccount struct { | |||
There was a problem hiding this comment.
It seems this is only would be for genesis module accounts. when a chain creates them dynamically this would fail because it may not be present correct? Maybe we name is something to identify genesis accounts or put it in the go doc
There was a problem hiding this comment.
wdym create them dynamically, like we create new module accounts besides the genesis one ?
a service in runtime right ? |
A service in core, implemented by runtime yes. |
Description
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.
I have...
Summary by CodeRabbit
These updates improve the overall functionality and flexibility of the application for users interacting with module accounts.