Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): Add get module accounts service to core appmodule #22138

Closed
wants to merge 2 commits into from
+11 −0
Closed

feat(core): Add get module accounts service to core appmodule #22138

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8db9f9e
add get account module service to core appmodule
sontrinh16 Oct 2, 2024
2540190
Merge branch 'main' into son/add_module_accounts_list
sontrinh16 Oct 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions core/appmodule/v2/module.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,3 +104,14 @@ type ValidatorUpdate struct {
type HasRegisterInterfaces interface {
RegisterInterfaces(registry.InterfaceRegistrar)
}

// ModuleAccount defines a module account info get from the module.
type ModuleAccount struct {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems this is only would be for genesis module accounts. when a chain creates them dynamically this would fail because it may not be present correct? Maybe we name is something to identify genesis accounts or put it in the go doc

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wdym create them dynamically, like we create new module accounts besides the genesis one ?

Name string
Address []byte
}

// HasModuleAccounts is implemented by a module which has module accounts.
type HasModuleAccounts interface {
GetModuleAccounts() []ModuleAccount
}
Loading