Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make social container element a span #236

Merged
merged 3 commits into from
Nov 26, 2023
Merged

Conversation

dejorrit
Copy link
Contributor

When using SocialIcon inside a <p> element you will see the following warning in your console:

Warning: validateDOMNesting(...): <div> cannot appear as a descendant of <p>.

This is triggered by the social-container div, so setting the as prop has no effect on this warning.

Fixed by changing this div into a span. Since the social-container is positioned absolute this has no visible effects.

@couetilc couetilc merged commit 51a796d into couetilc:main Nov 26, 2023
4 of 5 checks passed
@couetilc
Copy link
Owner

@dejorrit thank you for contributing, released in v6.7.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants