Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(website): website search #3948

Merged
merged 1 commit into from
Nov 11, 2024
Merged

Conversation

GermainBergeron
Copy link
Member

@GermainBergeron GermainBergeron commented Nov 11, 2024

Proposed Changes

Fixed the search not working. Updated the layout so it stops going under the navigation
I also removed the engine-strict=true so we can bump to node 22

Potential Breaking Changes

None, only affects the website

Acceptance Criteria

  • The proposed changes are covered by unit tests
  • The potential breaking changes are clearly identified
  • README.md is adjusted to reflect the proposed changes (if relevant)

Copy link

@GermainBergeron GermainBergeron marked this pull request as ready for review November 11, 2024 18:47
@GermainBergeron GermainBergeron requested a review from a team as a code owner November 11, 2024 18:47
@GermainBergeron GermainBergeron requested review from gdostie and FelixBlaisThon and removed request for a team November 11, 2024 18:47
@GermainBergeron GermainBergeron merged commit 5d85a8e into master Nov 11, 2024
6 checks passed
@GermainBergeron GermainBergeron deleted the fix/ADUI-10366-website-search branch November 11, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants