Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(website): website search #3948

Merged
merged 1 commit into from
Nov 11, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .npmrc
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
strict-peer-dependencies=false
save-exact=true
engine-strict=true
auto-install-peers=false
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -46,10 +46,11 @@
"devDependencies": {
"@commitlint/cli": "19.5.0",
"@commitlint/config-conventional": "19.5.0",
"@coveo/semantic-monorepo-tools": "2.4.59",
"@coveo/semantic-monorepo-tools": "2.5.4",
"@eslint/compat": "1.2.1",
"@sindresorhus/slugify": "2.2.1",
"@types/node": "20.16.13",
"@vitest/eslint-plugin": "1.1.7",
"aws-sdk": "2.1691.0",
"chokidar": "4.0.1",
"commitizen": "4.3.1",
Expand All @@ -65,7 +66,6 @@
"eslint-plugin-react-refresh": "0.4.12",
"eslint-plugin-testing-library": "6.4.0",
"eslint-plugin-unused-imports": "4.1.4",
"@vitest/eslint-plugin": "1.1.7",
"globals": "15.11.0",
"husky": "9.1.6",
"lint-staged": "15.2.10",
Expand Down
4 changes: 2 additions & 2 deletions packages/website/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@
"type-check": "tsc --noEmit"
},
"dependencies": {
"@coveo/atomic-react": "3.1.7",
"@coveo/headless": "3.4.0",
"@coveo/atomic-react": "3.2.4",
"@coveo/headless": "3.8.1",
"@coveord/plasma-components-props-analyzer": "workspace:*",
"@coveord/plasma-mantine": "workspace:*",
"@coveord/plasma-react-icons": "workspace:*",
Expand Down
4 changes: 2 additions & 2 deletions packages/website/src/building-blocs/ResultList.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -20,15 +20,15 @@ export const ResultList: FunctionComponent<ResultListProps> = ({controller, engi
return (
<>
{!state.hasResults && !state.isLoading ? (
<Container size="xl" className="home" pt="150">
<Container size="xl" className="home" pt="lg">
<Box w="100%">
<AtomicSearchInterface engine={engine}>
<NoSearchResultTemplate engine={engine} query={query} />
</AtomicSearchInterface>
</Box>
</Container>
) : (
<Container size="xl" className="home" pt="150">
<Container size="xl" className="home" pt="lg">
<Stack gap="md" flex="1">
<AtomicSearchInterface engine={engine}>
<AtomicQuerySummary />
Expand Down
7 changes: 6 additions & 1 deletion packages/website/src/pages/Search.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import {
loadSearchActions,
loadSearchAnalyticsActions,
} from '@coveo/headless';
import {AppShell} from '@coveord/plasma-mantine';
import {useContext} from 'react';
import {ResultList} from '../building-blocs/ResultList';
import {EngineContext} from '../search/engine/EngineContext';
Expand Down Expand Up @@ -39,7 +40,11 @@ const Search = () => {
}

const controller = buildResultList(engine);
return <ResultList controller={controller} engine={engine} query={query} />;
return (
<AppShell.Main>
<ResultList controller={controller} engine={engine} query={query} />
</AppShell.Main>
);
};

export default Search;
82 changes: 36 additions & 46 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.