Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies: Modernize to prepare unlocking more recent Python versions #543

Merged
merged 2 commits into from
Nov 12, 2024

Conversation

amotl
Copy link
Member

@amotl amotl commented Nov 6, 2024

About

A few adjustments to prepare unlocking Python 3.12 and eventually 3.13.
The patch mainly phases out use of pkg_resources and distutils.util.

@cla-bot cla-bot bot added the cla-signed label Nov 6, 2024
@amotl amotl marked this pull request as ready for review November 6, 2024 21:29
Comment on lines 63 to 69
"testing": [
"tox==3.14.2",
"pytest-freezegun==0.4.2",
"pytest<9",
"pytest-cov<7",
"pytest-freezer<0.5",
"pytest-random-order<2",
"tox<4",
],
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment on lines 4 to +5
[testenv]
deps = -r{toxinidir}/test-requirements.txt
deps = -e{toxinidir}[testing]
Copy link
Member Author

@amotl amotl Nov 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested invoking tox, but the change looks reasonable.

@@ -60,8 +61,11 @@
],
extras_require={
"testing": [
"tox==3.14.2",
"pytest-freezegun==0.4.2",
"pytest<9",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think in the past we tried to use == if possible instead of <.
I don't have a strong opinion about that. @Taliik What do you think about it?

Copy link
Member Author

@amotl amotl Nov 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it will be reasonable for stable requirements to have a more lenient version pinning, specifically in the "testing" section. That also reduces Dependabot spam. Let me know if you disagree.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with more lenient version pinning for testing 👍

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Will you acknowledge?

Copy link
Member

@Taliik Taliik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙇

@amotl amotl merged commit cc54aef into master Nov 12, 2024
11 checks passed
@amotl amotl deleted the modernize-2024 branch November 12, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants