-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dependencies: Modernize to prepare unlocking more recent Python versions #543
Conversation
"testing": [ | ||
"tox==3.14.2", | ||
"pytest-freezegun==0.4.2", | ||
"pytest<9", | ||
"pytest-cov<7", | ||
"pytest-freezer<0.5", | ||
"pytest-random-order<2", | ||
"tox<4", | ||
], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI: pytest-freezegun
got superseded by pytest-freezer
.
[testenv] | ||
deps = -r{toxinidir}/test-requirements.txt | ||
deps = -e{toxinidir}[testing] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't tested invoking tox
, but the change looks reasonable.
@@ -60,8 +61,11 @@ | |||
], | |||
extras_require={ | |||
"testing": [ | |||
"tox==3.14.2", | |||
"pytest-freezegun==0.4.2", | |||
"pytest<9", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think in the past we tried to use ==
if possible instead of <
.
I don't have a strong opinion about that. @Taliik What do you think about it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess it will be reasonable for stable requirements to have a more lenient version pinning, specifically in the "testing" section. That also reduces Dependabot spam. Let me know if you disagree.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with more lenient version pinning for testing 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Will you acknowledge?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙇
About
A few adjustments to prepare unlocking Python 3.12 and eventually 3.13.
The patch mainly phases out use of
pkg_resources
anddistutils.util
.