Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically update go.mod #50

Merged
merged 4 commits into from
May 31, 2024
Merged

Automatically update go.mod #50

merged 4 commits into from
May 31, 2024

Conversation

cfergeau
Copy link
Contributor

This automates some boring tasks we don't do often enough.

@cfergeau
Copy link
Contributor Author

I've updated again the go modules we depend on. This includes a go 1.21 update because of win-io.

@cfergeau cfergeau changed the title Automatically update go.mod, and enable code scanning with snyk Automatically update go.mod May 27, 2024
This is the latest version, and should fix some CI failures related to
this action.
@praveenkumar
Copy link
Member

Looks like CI is still failing because of the linter issue.

This fixes warnings with newer golangci-lint versions.

Signed-off-by: Christophe Fergeau <[email protected]>
@@ -10,7 +10,7 @@ import (
var Clean = &cobra.Command{
Use: "clean",
Short: "Clean all entries added with a particular suffix",
RunE: func(cmd *cobra.Command, args []string) error {
RunE: func(_ *cobra.Command, args []string) error {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@praveenkumar praveenkumar merged commit 4584e47 into crc-org:master May 31, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants