fix: remove omitempty in invalid json tag combination #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kevin Kendzia <[email protected]>
kkendzia
force-pushed
the
fix/remove_invalid_json_tag
branch
from
6118bc7 to
0d1914a
Compare
lsviben
approved these changes
Jan 8, 2025
|
Successfully created backport PR #263 for |
|
Successfully created backport PR #264 for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
As mentioned in crossplane/function-sdk-go#161 and further go-json-experiment/json#39 "inline,omitempty" is an invalid combination of json tags. This leads to issues in marshaling DataKeySelector.
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
We have tested the modified types.go locally in our e2e tests. This shouldn't be a breaking change as it wasn't working in crossplane functions until now. Also CRDs have not changed.
Would appreciate a 0.20 or even 0.19 backport