-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api): enable dynamic JFR start #165
feat(api): enable dynamic JFR start #165
Conversation
4c5db22
to
b82237f
Compare
b82237f
to
2f4cbc3
Compare
I see an error when I run with 2.22.0 core, built agent quarkus test, and the dependent cryostat pr, does anyone else have this or is it my problem again? podman run \
--name quarkus-test-agent-2 \
--pod cryostat-pod \
--env JAVA_OPTS="-Dquarkus.http.host=0.0.0.0 -Djava.util.logging.manager=org.jboss.logmanager.LogManager -javaagent:/deployments/app/cryostat-agent.jar" \
--env QUARKUS_HTTP_PORT=10011 \
--env ORG_ACME_CRYOSTATSERVICE_ENABLED="false" \
--env CRYOSTAT_AGENT_APP_NAME="quarkus-test-agent" \
--env CRYOSTAT_AGENT_WEBCLIENT_SSL_TRUST_ALL="true" \
--env CRYOSTAT_AGENT_WEBCLIENT_SSL_VERIFY_HOSTNAME="false" \
--env CRYOSTAT_AGENT_WEBSERVER_HOST="localhost" \
--env CRYOSTAT_AGENT_WEBSERVER_PORT="9988" \
--env CRYOSTAT_AGENT_CALLBACK="http://localhost:9988/" \
--env CRYOSTAT_AGENT_BASEURI="${protocol}://localhost:${webPort}/" \
--env CRYOSTAT_AGENT_TRUST_ALL="true" \
--env CRYOSTAT_AGENT_AUTHORIZATION="Basic $(echo user:pass | base64)" \
--env CRYOSTAT_AGENT_REGISTRATION_PREFER_JMX="true" \
--env CRYOSTAT_AGENT_API_WRITES_ENABLED="true" \
--rm -d quay.io/andrewazores/quarkus-test:latest |
I just tried it again and it worked fine. The exception you see is the same as what I see when I try to create a recording on ex. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
0a60a1f
into
cryostatio:124-epic-two-way-communications-protocol
* end paths with / so as to not match by prefix * only allow GET requests if write-operations are not enabled * feat(api): implement GET /recordings/:id for streaming files * feat(api): enable dynamic JFR start (#165) * feat(api): enable dynamic JFR stop, delete (#176) Co-authored-by: Ming Wang <[email protected]>
Fixes #163
Fixes #164
Depends on cryostatio/cryostat-core#245
Not yet implemented: restarting already existing recordings, manual stop of running recordings, opening stream (download) recordings. This only enables the ability to remotely start a recording over HTTP.